From mboxrd@z Thu Jan 1 00:00:00 1970 From: Baruch Even Subject: Re: netif_rx packet dumping Date: Tue, 08 Mar 2005 18:01:01 +0000 Message-ID: <422DE85D.1010901@ev-en.org> References: <20050303123811.4d934249@dxpl.pdx.osdl.net> <42278122.6000000@ev-en.org> <20050303133659.0d224e61.davem@davemloft.net> <42278554.2090902@ev-en.org> <20050303135718.2e1a0170.davem@davemloft.net> <422DC7CE.2040800@ev-en.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: shemminger@osdl.org, netdev@oss.sgi.com To: Andi Kleen In-Reply-To: Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com List-Id: netdev.vger.kernel.org Andi Kleen wrote: > Baruch Even writes: > >>I can squeeze the tcp_skb_cb to one pointer at the expense of extra >>work to remove a packet from the list (the other pointer is the prev >>pointer). > > You could also use a xor list in theory. But I'm not sure it's worth it. > Increasing cb by 4 bytes shouldn't be a very big issue. If increasing the cb by 4 bytes is ok, it would make my life easier and the code simpler. But I don't think it would also be a big issue to remove the prev pointer. Now, if we can agree on increasing the tcp_sock by 20 bytes I'll be able to continue my work. Baruch