From: Patrick McHardy <kaber@trash.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Steve Hill <steve@services.navaho.net>,
netdev@oss.sgi.com, "David S. Miller" <davem@davemloft.net>
Subject: Re: More IPSEC trouble
Date: Sat, 12 Mar 2005 03:35:46 +0100 [thread overview]
Message-ID: <42325582.1090003@trash.net> (raw)
In-Reply-To: <20050312013515.GA17539@gondor.apana.org.au>
Herbert Xu wrote:
> Good catch. However let's try to avoid spreading lock/unlock calls
> around if possible.
>
> Since tunnel_check_size only looks at the state to determine whether
> it's tunnel mode, it doesn't need to hold the lock at all.
Agreed, your patch is better.
Regards
Patrick
next prev parent reply other threads:[~2005-03-12 2:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-10 12:45 More IPSEC trouble Steve Hill
2005-03-10 15:01 ` Nicolas DICHTEL
2005-03-10 16:32 ` Steve Hill
2005-03-10 17:15 ` Patrick McHardy
2005-03-11 1:17 ` Herbert Xu
2005-03-11 15:05 ` Steve Hill
2005-03-12 0:00 ` Patrick McHardy
2005-03-12 0:11 ` Patrick McHardy
2005-03-12 0:13 ` Patrick McHardy
2005-03-12 1:35 ` Herbert Xu
2005-03-12 2:35 ` Patrick McHardy [this message]
2005-03-14 12:12 ` Steve Hill
2005-03-15 5:39 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42325582.1090003@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@oss.sgi.com \
--cc=steve@services.navaho.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).