From: Nivedita Singhvi <niv@us.ibm.com>
To: Chuck Ebbert <76306.1226@compuserve.com>
Cc: linux-netdev <netdev@oss.sgi.com>, Andrew Morton <akpm@osdl.org>,
Christoph Lameter <clameter@sgi.com>
Subject: Re: [PATCH] Optimize loopback stats
Date: Tue, 15 Mar 2005 12:49:51 -0800 [thread overview]
Message-ID: <42374A6F.50300@us.ibm.com> (raw)
In-Reply-To: <4237423E.2040505@us.ibm.com>
Nivedita Singhvi wrote:
> Chuck Ebbert wrote:
>
>> This patch optimizes the loopback driver's statistics by using a single
>> counter for rx and tx stats instead of one for rx and one for tx. It
>> also
>> adds unlikely() to the test for TSO since it's no longer supported by
>> default.
>> (Maybe the TSO code should be bracketed by "#if 0" ?)
>
>
> Hmm, some of us want those counters separate - if this is really
> needed, could it be a configurable option, please?
Or we could live with the appropriate patches to ip, ifconfig,
reporting them separately (halving them). That would be fine.
thanks,
Nivedita
next prev parent reply other threads:[~2005-03-15 20:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-15 19:56 [PATCH] Optimize loopback stats Chuck Ebbert
2005-03-15 20:14 ` Nivedita Singhvi
2005-03-15 20:49 ` Nivedita Singhvi [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-03-15 23:15 Chuck Ebbert
2005-03-16 0:09 ` Nivedita Singhvi
2005-03-16 0:18 ` Nivedita Singhvi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42374A6F.50300@us.ibm.com \
--to=niv@us.ibm.com \
--cc=76306.1226@compuserve.com \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).