From: Nivedita Singhvi <niv@us.ibm.com>
To: Nivedita Singhvi <niv@us.ibm.com>
Cc: Chuck Ebbert <76306.1226@compuserve.com>,
Christoph Lameter <clameter@sgi.com>,
Andrew Morton <akpm@osdl.org>, linux-netdev <netdev@oss.sgi.com>
Subject: Re: [PATCH] Optimize loopback stats
Date: Tue, 15 Mar 2005 16:18:42 -0800 [thread overview]
Message-ID: <42377B62.6070606@us.ibm.com> (raw)
In-Reply-To: <42377947.5090207@us.ibm.com>
> Hmm, I see the following in your patch:
>
> + stats->rx_bytes += lb_stats->rx_tx_bytes;
> + stats->tx_bytes = stats->rx_bytes;
>
> Doesn't that mean RX is now twice what it should be
> and so is TX? They are separately reported, but if
> so, their real value should be half of rx_tx_bytes
> each, correct?
Ah, just beat me silly with a cluestick.
I see what you're doing now..it's fine.
thanks,
Nivedita
next prev parent reply other threads:[~2005-03-16 0:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-15 23:15 [PATCH] Optimize loopback stats Chuck Ebbert
2005-03-16 0:09 ` Nivedita Singhvi
2005-03-16 0:18 ` Nivedita Singhvi [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-03-15 19:56 Chuck Ebbert
2005-03-15 20:14 ` Nivedita Singhvi
2005-03-15 20:49 ` Nivedita Singhvi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42377B62.6070606@us.ibm.com \
--to=niv@us.ibm.com \
--cc=76306.1226@compuserve.com \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).