From: Eric Dumazet <dada1@cosmosbay.com>
To: "David S. Miller" <davem@redhat.com>, netdev@oss.sgi.com
Subject: [PATCH,resent] reduce sizeof(struct inet_peer) from 128 to 64 bytes on 64bits architectures
Date: Thu, 17 Mar 2005 00:38:48 +0100 [thread overview]
Message-ID: <4238C388.5040303@cosmosbay.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 303 bytes --]
Resent with diff file not tab/space mangled :(
As peer_cachep uses kmem_cache_create("inet_peer_cache", ... SLAB_HWCACHE_ALIGN ...),
better try to use exactly 64 bytes instead of 72 for struct inet_peer.
This also means that this structure fits in one cache line on x86_64.
Thank you
Eric Dumazet
[-- Attachment #2: diff --]
[-- Type: text/plain, Size: 597 bytes --]
diff -Nru linux-2.6.11/include/net/inetpeer.h linux-2.6.11-ed/include/net/inetpeer.h
--- linux-2.6.11/include/net/inetpeer.h 2005-03-02 08:37:48.000000000 +0100
+++ linux-2.6.11-ed/include/net/inetpeer.h 2005-03-16 18:52:49.000000000 +0100
@@ -19,9 +19,9 @@
{
struct inet_peer *avl_left, *avl_right;
struct inet_peer *unused_next, **unused_prevp;
- atomic_t refcnt;
unsigned long dtime; /* the time of last use of not
* referenced entries */
+ atomic_t refcnt;
__u32 v4daddr; /* peer's address */
__u16 avl_height;
__u16 ip_id_count; /* IP ID for the next packet */
next reply other threads:[~2005-03-16 23:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-16 23:38 Eric Dumazet [this message]
2005-03-17 4:54 ` [PATCH,resent] reduce sizeof(struct inet_peer) from 128 to 64 bytes on 64bits architectures David S. Miller
2005-03-18 12:05 ` [PATCH] /proc/net/stat/rt_cache has a wrong header Eric Dumazet
2005-03-18 16:50 ` Stephen Hemminger
2005-03-18 17:14 ` Eric Dumazet
2005-03-18 17:26 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4238C388.5040303@cosmosbay.com \
--to=dada1@cosmosbay.com \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).