netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Dumazet <dada1@cosmosbay.com>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: Stephen Hemminger <shemminger@osdl.org>,
	acme@conectiva.com.br, "David S. Miller" <davem@redhat.com>,
	netdev@oss.sgi.com
Subject: Re: [PATCH] /proc/net/stat/rt_cache has a wrong header
Date: Fri, 18 Mar 2005 18:26:00 +0100	[thread overview]
Message-ID: <423B0F28.3040508@cosmosbay.com> (raw)
In-Reply-To: <423B0C58.10709@cosmosbay.com>

Eric Dumazet a écrit :

> AFAIK the old stat file (/proc/net/rt_cache_acct) was OK.
> 
> During the conversion to /proc/net/stat/rt_cache done in late 2.6.XX 
> version, a bug was introduced, in kernel and also in iproute2.
> 
> The API if fine, and my patch doesnt change it.
> 
> Eric
> 
> 

I should give more explanations about the bug :

Each line contains 17 fields.

But the header contains only 16 fields, one column (in_slow_mc, the 4th field) was forgotten.

Thus rtstat (from last iproute2) gives wrong information starting at 4th column.

Eric

      reply	other threads:[~2005-03-18 17:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-16 23:38 [PATCH,resent] reduce sizeof(struct inet_peer) from 128 to 64 bytes on 64bits architectures Eric Dumazet
2005-03-17  4:54 ` David S. Miller
2005-03-18 12:05 ` [PATCH] /proc/net/stat/rt_cache has a wrong header Eric Dumazet
2005-03-18 16:50   ` Stephen Hemminger
2005-03-18 17:14     ` Eric Dumazet
2005-03-18 17:26       ` Eric Dumazet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=423B0F28.3040508@cosmosbay.com \
    --to=dada1@cosmosbay.com \
    --cc=acme@conectiva.com.br \
    --cc=davem@redhat.com \
    --cc=netdev@oss.sgi.com \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).