From: Baruch Even <baruch@ev-en.org>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: Andrew Morton <akpm@digeo.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@oss.sgi.com, Injong Rhee <rhee@eos.ncsu.edu>
Subject: Re: [PATCH 1/5] TCP infrastructure split out
Date: Sat, 19 Mar 2005 02:16:40 +0000 [thread overview]
Message-ID: <423B8B88.70504@ev-en.org> (raw)
In-Reply-To: <20050318162221.501ff05a@dxpl.pdx.osdl.net>
Stephen Hemminger wrote:
> @@ -1356,7 +1301,7 @@
> static inline void __tcp_enter_cwr(struct tcp_sock *tp)
> {
> tp->undo_marker = 0;
> - tp->snd_ssthresh = tcp_recalc_ssthresh(tp);
> + tp->snd_ssthresh = tp->ca_proto->ssthresh(tp);
> +void tcp_ca_register(struct tcp_ca_type *ca)
> +{
> + BUG_ON(tcp_ca_find(ca->name));
> +
> + spin_lock_irq(&tcp_ca_list_lock);
> + list_add_tail_rcu(&ca->list, &tcp_ca_list);
> + spin_unlock_irq(&tcp_ca_list_lock);
> +
> + printk(KERN_INFO "TCP %s registered\n", ca->name);
> +}
Since we have some calls to callbacks unprotected, shouldn't we check
them on tcp_ca_register to make sure they are in fact available so that
we don't needlessly crash?
Baruch
prev parent reply other threads:[~2005-03-19 2:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-19 0:22 [PATCH 1/5] TCP infrastructure split out Stephen Hemminger
2005-03-19 2:16 ` Baruch Even [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=423B8B88.70504@ev-en.org \
--to=baruch@ev-en.org \
--cc=akpm@digeo.com \
--cc=davem@davemloft.net \
--cc=netdev@oss.sgi.com \
--cc=rhee@eos.ncsu.edu \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).