From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Mika_Penttil=E4?= Subject: Re: [15/*] [INET] Fix IPsec calculation in ip_append_data/ip6_append_data Date: Mon, 21 Mar 2005 23:29:58 +0200 Message-ID: <423F3CD6.7090109@kolumbus.fi> References: <20050214221607.GC18465@gondor.apana.org.au> <20050306213214.7d8a143d.davem@davemloft.net> <20050307103536.GB7137@gondor.apana.org.au> <20050308102741.GA23468@gondor.apana.org.au> <20050314102614.GA9610@gondor.apana.org.au> <20050314105313.GA21001@gondor.apana.org.au> <20050314111002.GA29156@gondor.apana.org.au> <20050315091904.GA6256@gondor.apana.org.au> <20050316113149.GA10960@gondor.apana.org.au> <423EF2CF.7020403@kolumbus.fi> <20050321202804.GA3106@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , Alexey Kuznetsov , YOSHIFUJI Hideaki , Patrick McHardy , netdev@oss.sgi.com To: Herbert Xu In-Reply-To: <20050321202804.GA3106@gondor.apana.org.au> Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com List-Id: netdev.vger.kernel.org Herbert Xu wrote: >On Mon, Mar 21, 2005 at 06:14:07PM +0200, Mika Penttil? wrote: > > >>Shouldn't ip_output also use the path variant, dst_mtu(skb->dst->path), >>it's surely after ipsec- processing? >> >> > >That's the reason why it shouldn't use dst->path. The only time you >should use dst_mtu(dst->path) is when dst may contain IPsec AND you >need the MTU outside IPsec. > >In this case dst cannot contain IPsec so dst_mtu(dst) is correct. > >Cheers, > > ok I see it now, but this is really easy to get wrong... Thanks, Mika