From: Jeff Garzik <jgarzik@pobox.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Don Fry <brazilnut@us.ibm.com>,
davem@davemloft.net, netdev@oss.sgi.com,
steven.hardy@astrium.eads.net
Subject: Re: [patch 12/13] pcnet32 79C975 fiber fix
Date: Tue, 22 Mar 2005 14:14:09 -0500 [thread overview]
Message-ID: <42406E81.3090202@pobox.com> (raw)
In-Reply-To: <20050315170322.3398bd60.akpm@osdl.org>
Andrew Morton wrote:
> Don Fry <brazilnut@us.ibm.com> wrote:
>
>>I had not seen this problem until now. The patch looks ok and
>> probably should have been written that way initially. I have been
>> able to do a quick touch test with a 970A, 971, 972, 973, 975, 976, and
>> 978 (some on ia32 and others on ppc64) without any adverse effects.
>> The 975 I have is copper not fiber.
>
>
> Great, thanks.
>
>
>> Since only bit 12 is needed to enable LED writes, the code could
>> really be "a->write_bcr(ioaddr, 2, a->read_bcr(ioaddr, 2) | 0x1000);"
>> During pcnet32_open the ASEL bit is changed anyway.
>
>
> OK, could you please prepare a final patch sometime and get it into Jeff?
> cc me as well please so I can update the patch I have.
Yes, please do Don, if you have the time.
Jeff
prev parent reply other threads:[~2005-03-22 19:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-15 22:22 [patch 12/13] pcnet32 79C975 fiber fix akpm
2005-03-16 0:56 ` Don Fry
2005-03-16 1:03 ` Andrew Morton
2005-03-22 19:14 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42406E81.3090202@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=brazilnut@us.ibm.com \
--cc=davem@davemloft.net \
--cc=netdev@oss.sgi.com \
--cc=steven.hardy@astrium.eads.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).