From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff Garzik <jgarzik@pobox.com>
Subject: Re: [patch 14/26] net/slip: replace schedule_timeout() with msleep()
Date: Tue, 22 Mar 2005 18:59:14 -0500
Message-ID: <4240B152.4080904@pobox.com>
References: <20050306103322.857041F203@trashy.coderock.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: netdev@oss.sgi.com, nacc@us.ibm.com
To: domen@coderock.org
In-Reply-To: <20050306103322.857041F203@trashy.coderock.org>
Sender: netdev-bounce@oss.sgi.com
Errors-to: netdev-bounce@oss.sgi.com
List-Id: netdev.vger.kernel.org

domen@coderock.org wrote:
> Use msleep() instead of schedule_timeout() to guarantee
> the task delays as expected. While the original code does use
> TASK_INTERRUPTIBLE, it does not check for signals, so I believe msleep() is more
> appropriate.
> 
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
> Signed-off-by: Domen Puncer <domen@coderock.org>
> ---
> 
> 
>  kj-domen/drivers/net/slip.c |    7 +++----
>  1 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff -puN drivers/net/slip.c~msleep-drivers_net_slip drivers/net/slip.c
> --- kj/drivers/net/slip.c~msleep-drivers_net_slip	2005-03-05 16:10:49.000000000 +0100
> +++ kj-domen/drivers/net/slip.c	2005-03-05 16:10:49.000000000 +0100
> @@ -75,6 +75,7 @@
>  #include <linux/if_arp.h>
>  #include <linux/if_slip.h>
>  #include <linux/init.h>
> +#include <linux/delay.h>
>  #include "slip.h"
>  #ifdef CONFIG_INET
>  #include <linux/ip.h>
> @@ -1395,10 +1396,8 @@ static void __exit slip_exit(void)
>  	/* First of all: check for active disciplines and hangup them.
>  	 */
>  	do {
> -		if (busy) {
> -			set_current_state(TASK_INTERRUPTIBLE);
> -			schedule_timeout(HZ / 10);
> -		}
> +		if (busy)
> +			msleep(100);

msleep_interruptible