From: Patrick McHardy <kaber@trash.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: akpm@osdl.org, netdev@oss.sgi.com, o.cornu@gmail.com, paulus@samba.org
Subject: Re: Fw: [Bugme-new] [Bug 4381] New: When i try to start a pppoe conn., crash at net/core/skbuff.c:91
Date: Wed, 23 Mar 2005 03:55:09 +0100 [thread overview]
Message-ID: <4240DA8D.1050906@trash.net> (raw)
In-Reply-To: <E1DDvvZ-000350-00@gondolin.me.apana.org.au>
Herbert Xu wrote:
> Patrick McHardy <kaber@trash.net> wrote:
>
>>===== drivers/net/ppp_async.c 1.26 vs edited =====
>>--- 1.26/drivers/net/ppp_async.c 2005-01-21 06:02:12 +01:00
>>+++ edited/drivers/net/ppp_async.c 2005-03-23 03:15:31 +01:00
>>@@ -183,6 +183,7 @@
>> ap->chan.private = ap;
>> ap->chan.ops = &async_ops;
>> ap->chan.mtu = PPP_MRU;
>>+ ap->chan.hdrlen = 2;
>> err = ppp_register_channel(&ap->chan);
>
>
> I'm not sure whether this could cause the original crash that we saw.
> If ap->chan.hdrlen is not set then it should be zero. It being zero
> should not cause skb_over_panic to trigger in ppp_write, should it?
You're right, I missed the memset().
Regards
Patrick
next prev parent reply other threads:[~2005-03-23 2:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-22 4:11 Fw: [Bugme-new] [Bug 4381] New: When i try to start a pppoe conn., crash at net/core/skbuff.c:91 Andrew Morton
2005-03-23 2:20 ` Patrick McHardy
2005-03-23 2:49 ` Herbert Xu
2005-03-23 2:55 ` Patrick McHardy [this message]
2005-03-23 3:06 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4240DA8D.1050906@trash.net \
--to=kaber@trash.net \
--cc=akpm@osdl.org \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@oss.sgi.com \
--cc=o.cornu@gmail.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).