From: Jeff Garzik <jgarzik@pobox.com>
To: Vicente Feito <vicente.feito@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@oss.sgi.com
Subject: Re: [PATCH 2.6.12-rc1-mm1] net/ethernet/eth.c - eth_header
Date: Wed, 23 Mar 2005 15:50:25 -0500 [thread overview]
Message-ID: <4241D691.5000707@pobox.com> (raw)
In-Reply-To: <200503231734.59277.vicente.feito@gmail.com>
Vicente Feito wrote:
> Hi,
> Please consider applying (or droping).
> Thank you.
>
> Description: This patch prevent drivers from calling eth_header with a 802.3
> frame using a len>1536. In such a case returns -EINVAL, which was hard to
> choose because the ETH_HLEN is supposed to return.
>
> Signed-off-by: Vicente Feito <vicente.feito@gmail.com>
>
>
> ------------------------------------------------------------------------
>
> --- linux-2.6.12-rc1-mm1/net/ethernet/eth.c.orig 2005-03-22 12:49:08.000000000 +0000
> +++ linux-2.6.12-rc1-mm1/net/ethernet/eth.c 2005-03-22 12:49:36.000000000 +0000
> @@ -78,6 +78,8 @@ int eth_header(struct sk_buff *skb, stru
> {
> struct ethhdr *eth = (struct ethhdr *)skb_push(skb,ETH_HLEN);
>
> + if (type == ETH_P_802_3 && len >= 1536)
> + return -EINVAL;
Why? Won't this break for jumbo frames?
Jeff
next prev parent reply other threads:[~2005-03-23 20:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-23 17:34 [PATCH 2.6.12-rc1-mm1] net/ethernet/eth.c - eth_header Vicente Feito
2005-03-23 20:50 ` Jeff Garzik [this message]
2005-03-23 18:15 ` Vicente Feito
2005-03-23 21:25 ` Jon Mason
2005-03-23 20:52 ` Jon Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4241D691.5000707@pobox.com \
--to=jgarzik@pobox.com \
--cc=davem@davemloft.net \
--cc=netdev@oss.sgi.com \
--cc=vicente.feito@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).