netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Thomas Graf <tgraf@suug.ch>
Cc: "'netdev@oss.sgi.com'" <netdev@oss.sgi.com>
Subject: Re: af_packet.c bug?
Date: Mon, 28 Mar 2005 12:33:41 -0800	[thread overview]
Message-ID: <42486A25.7080001@candelatech.com> (raw)
In-Reply-To: <20050328201738.GG3086@postel.suug.ch>

Thomas Graf wrote:
> * Ben Greear <4248642E.40304@candelatech.com> 2005-03-28 12:08
> 
>>>Seems so, please adopt the size of spkt_device in struct sockaddr_pkt
>>
>>you mean adapt maybe?
> 
> 
> Of course, stupid typo. ;->
> 
>>I was also wondering why we couldn't hold a reference to the net-device
>>instead of just it's ifindex when dealing with a bound raw socket.
> 
> 
> Saving a netdevice handle in the packet socket is not a problem but
> doing the same for the packet socket address seems to be non trivial.

Yes.  But assuming you bind the socket, you use the device saved in the packet
socket.  If you are sending to a particular device for each send(), then you'll
just have to pay the lookup costs.  I haven't looked recently, but didn't someone
finally hash the device lookup so that it's not a linear walk of the device
list now?

Ben



-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

  reply	other threads:[~2005-03-28 20:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-28 19:19 af_packet.c bug? Ben Greear
2005-03-28 19:55 ` Thomas Graf
2005-03-28 20:08   ` Ben Greear
2005-03-28 20:17     ` Thomas Graf
2005-03-28 20:33       ` Ben Greear [this message]
2005-03-28 20:18     ` David S. Miller
2005-03-28 20:30       ` Ben Greear
2005-03-28 20:33         ` David S. Miller
2005-04-01  4:59   ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42486A25.7080001@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=netdev@oss.sgi.com \
    --cc=tgraf@suug.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).