From: Jeff Garzik <jgarzik@pobox.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, schwidefsky@de.ibm.com, netdev@oss.sgi.com
Subject: Re: [PATCH] s390: claw network device driver
Date: Tue, 29 Mar 2005 02:44:35 -0500 [thread overview]
Message-ID: <42490763.5010008@pobox.com> (raw)
In-Reply-To: <20050328232359.4f1e04b9.akpm@osdl.org>
Andrew Morton wrote:
> Jeff Garzik <jgarzik@pobox.com> wrote:
>
>> > Was cc'ed to linux-net last Thursday, but it looks like the messages was
>> > too large and the vger server munched it.
>>
>> This also brings up a larger question... why was a completely unreviewed
>> net driver merged?
>
>
> Because nobody noticed that it didn't make it to the mailing list,
> obviously.
That's ducking the question. Let me rephrase.
Why was a complete lack of response judged to be an ACK?
For new drivers, that's a -horrible- precedent. You are quite skilled
at poking random hackers :) why not poke somebody to ack a new drivers?
It's not like this driver (or many of the other new drivers)
desperately need to get into the kernel ASAP, so desperate that a lack
of review was OK.
Jeff
next prev parent reply other threads:[~2005-03-29 7:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200503290533.j2T5XEYT028850@hera.kernel.org>
[not found] ` <4248FBFD.5000809@pobox.com>
2005-03-29 7:08 ` [PATCH] s390: claw network device driver Andrew Morton
2005-03-29 7:10 ` Jeff Garzik
2005-03-29 7:48 ` Martin Schwidefsky
2005-03-29 20:05 ` Jeff Garzik
2005-03-30 7:49 ` Martin Schwidefsky
2005-03-29 15:20 ` Jörn Engel
2005-03-29 20:06 ` Jeff Garzik
2005-03-29 21:25 ` Jörn Engel
2005-03-29 22:44 ` Jeff Garzik
2005-03-30 9:49 ` Jörn Engel
2005-04-08 20:16 ` Pavel Machek
2005-04-09 13:52 ` Jörn Engel
2005-04-12 6:20 ` [PATCH] Maintainers list update: linux-net -> netdev Horms
2005-04-12 19:14 ` George Anzinger
2005-04-13 2:14 ` Horms
2005-04-13 22:42 ` George Anzinger
2005-03-29 7:12 ` [PATCH] s390: claw network device driver Jeff Garzik
2005-03-29 7:23 ` Andrew Morton
2005-03-29 7:44 ` Jeff Garzik [this message]
2005-03-29 8:02 ` Andrew Morton
2005-03-29 20:02 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42490763.5010008@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).