Stephen Hemminger wrote:
> You need to cleanup the style.  
> 	Lots of dead commented out code.

Ok, think I got rid of most of the dead code and commented code.  I left
in the commented printks in case I need to do more debugging.

> 	Encapsulating locking in macros is ugly and makes maintenance a nuisance.

Changed to just support spin locks and got rid of the macros.

>        CamelCaps

No idea what you mean here.  Do you want JavaStyleCapitalization?

>         Use prdebug instead of DEBUG

Just changed the DEBUG to printk and commented them out.

> 	RCU instead of rwlock's or just use spinlock

Used spin-lock.  The rwlock code was never tested or enabled anyway.

> 	Adding new /proc interfaces is frowned on

I want to keep this.  I want quick script access to configure the devices so I don't
have to maintain a rddconfig c program that uses ioctls.

> 	Adding new ioctl's are very frowned on

Bummer.  I want these as well, makes programatic reading of the information
much easier than trying to parse some proc file.  I will look into what it
takes to make them compat with 64-bit as DaveM suggested.

> 	global namespace issues with toupper et a..

Purged it, it was dead code.

Please see if the attached code looks better to you.

Thanks!
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com