From: Mike Christie <michaelc@cs.wisc.edu>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Dmitry Yusupov <dmitry_yus@yahoo.com>,
netdev@oss.sgi.com, davem@davemloft.net
Subject: Re: [PATCH] NETLINK_UESTABLISHED notifier event
Date: Wed, 06 Apr 2005 09:23:15 -0700 [thread overview]
Message-ID: <42540CF3.7070501@cs.wisc.edu> (raw)
In-Reply-To: <E1DJ0YI-0003PR-00@gondolin.me.apana.org.au>
Herbert Xu wrote:
> Dmitry Yusupov <dmitry_yus@yahoo.com> wrote:
>>* netlink alloc_skb() now uses sk_allocation instead of hard-coded
>>GFP_KERNEL
>
>
> Why? We never set it to anything else for netlink.
>
It is due to where it is being used. open-iscsi uses netlink
sockets for communication in a block (scsi specificically)
driver that has pushed much of its code to usersapce. Forcing
open-iscsi to use GFP_KERNEL causes a couple of problems. The
worst would be where a GFP_KERNEL allocation causes a write,
and that write is to an iscsi disk that open-iscsi is managing.
The write could then hit the same code path and cause another
GFP_KERNEL allocation and we could loop like that until the
system locks up.
next prev parent reply other threads:[~2005-04-06 16:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-05 19:54 [PATCH] NETLINK_UESTABLISHED notifier event Dmitry Yusupov
2005-04-05 21:39 ` Jean-Mickael Guerin
2005-04-05 23:53 ` Dmitry Yusupov
2005-04-06 0:13 ` Dmitry Yusupov
2005-04-06 2:45 ` Herbert Xu
2005-04-06 5:55 ` Dmitry Yusupov
2005-04-06 6:03 ` Herbert Xu
2005-04-06 15:16 ` Dmitry Yusupov
2005-04-06 16:23 ` Mike Christie [this message]
2005-04-06 21:29 ` Herbert Xu
2005-04-06 21:37 ` Dmitry Yusupov
2005-04-06 22:04 ` Herbert Xu
2005-04-06 22:26 ` Dmitry Yusupov
2005-04-07 11:30 ` jamal
2005-04-07 15:05 ` Dmitry Yusupov
2005-04-07 21:32 ` Herbert Xu
2005-04-07 23:36 ` Dmitry Yusupov
2005-04-08 11:36 ` Herbert Xu
2005-04-08 15:30 ` Dmitry Yusupov
2005-04-09 1:44 ` Herbert Xu
2005-04-09 16:02 ` Dmitry Yusupov
2005-04-09 19:36 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42540CF3.7070501@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=davem@davemloft.net \
--cc=dmitry_yus@yahoo.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).