netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Thomas Graf <tgraf@suug.ch>, Steven Rostedt <rostedt@goodmis.org>,
	hadi@cyberus.ca, netdev <netdev@oss.sgi.com>,
	Tarhon-Onu Victor <mituc@iasi.rdsnet.ro>,
	kuznet@ms2.inr.ac.ru, devik@cdi.cz, linux-kernel@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: ACPI/HT or Packet Scheduler BUG?
Date: Sun, 17 Apr 2005 19:46:16 +0200	[thread overview]
Message-ID: <4262A0E8.9020905@trash.net> (raw)
In-Reply-To: <20050416111236.GA31550@gondor.apana.org.au>

Herbert Xu wrote:
> On Sat, Apr 16, 2005 at 01:06:39PM +0200, Thomas Graf wrote:
> 
>>qdisc_destroy can still be invoked without qdisc_tree_lock via the
>>deletion of a class when it calls qdisc_destroy to destroy its
>>leaf qdisc.
>
> Indeed.  Fortuantely HTB seems to be safe as it calls sch_tree_lock
> which is another name for qdisc_tree_lock.  CBQ on the other hand
> needs to have a little tweak.

HTB also needs to be fixed. Destruction is usually defered by the
refcnt until ->put(), htb_put() doesn't lock the tree. Same for
HFSC and CBQ.

Regards
Patrick

  reply	other threads:[~2005-04-17 17:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Pine.LNX.4.61.0504081225510.27991@blackblue.iasi.rdsnet.ro>
     [not found] ` <Pine.LNX.4.61.0504121526550.4822@blackblue.iasi.rdsnet.ro>
     [not found]   ` <Pine.LNX.4.61.0504141840420.13546@blackblue.iasi.rdsnet.ro>
     [not found]     ` <1113601029.4294.80.camel@localhost.localdomain>
2005-04-15 21:44       ` ACPI/HT or Packet Scheduler BUG? jamal
2005-04-15 21:54         ` Steven Rostedt
2005-04-15 22:54           ` Thomas Graf
2005-04-16  1:49             ` Herbert Xu
2005-04-16  5:01               ` Steven Rostedt
2005-04-16 11:06               ` Thomas Graf
2005-04-16 11:12                 ` Herbert Xu
2005-04-17 17:46                   ` Patrick McHardy [this message]
2005-04-17 21:37                     ` Herbert Xu
2005-04-16 11:23                 ` Herbert Xu
2005-04-16 11:34                   ` Thomas Graf
2005-04-16 16:04                     ` jamal
2005-04-16 18:21                       ` Thomas Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4262A0E8.9020905@trash.net \
    --to=kaber@trash.net \
    --cc=davem@davemloft.net \
    --cc=devik@cdi.cz \
    --cc=hadi@cyberus.ca \
    --cc=herbert@gondor.apana.org.au \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mituc@iasi.rdsnet.ro \
    --cc=netdev@oss.sgi.com \
    --cc=rostedt@goodmis.org \
    --cc=tgraf@suug.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).