From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BB9BC77B60 for ; Sun, 30 Apr 2023 12:53:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229659AbjD3MxW (ORCPT ); Sun, 30 Apr 2023 08:53:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229461AbjD3MxV (ORCPT ); Sun, 30 Apr 2023 08:53:21 -0400 Received: from sender4-op-o10.zoho.com (sender4-op-o10.zoho.com [136.143.188.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9968213E; Sun, 30 Apr 2023 05:53:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682859173; cv=none; d=zohomail.com; s=zohoarc; b=JJtlInMc88s5cFIFmb+28p/VR0ERmgrMdExIpBCVB2u0u51AvybL5+lXT+Qr8+1bruuRToPe9C2vL77iPL4Qc2Lq+TTwXjsll72KaJa8HLIVQmux8TVoNWKy/x7T+Kzq+2JZqo69smHGOmiJ3x6+Km8cK0LhTlFeeDMezTja5CY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1682859173; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=olgWYWHl3CQIZVN3meZ6Pp4mpjNF3JJSDCCjo5V0hYc=; b=bw/iSmSCLJJScNpdJHpLmt3Ngo1oZI2SRyiGgwByfPoI6qD0NffUNwdMEW/w0Dd3/U7QKBMaUFbIrY2iQTFR46L/f4TYOZ5c0hE3bDa+EQ3mUTKJ8d22wCkxScG/wqmCKcMG2xu5oOglBpoS2ByApYASHATpFyX54LvgPIZS54g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=arinc9.com; spf=pass smtp.mailfrom=arinc.unal@arinc9.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1682859173; s=zmail; d=arinc9.com; i=arinc.unal@arinc9.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=olgWYWHl3CQIZVN3meZ6Pp4mpjNF3JJSDCCjo5V0hYc=; b=bf53awNY/1fwqOZeqetH9iXc8AzrtW5xOObM24CSmkh/GNMH9sBZT9fMXX67Abqm jyUrpzciSMxqsobNeCXeXBDjyDN4ZGKGlJ7OX6rdoD1H4Bbk7ds01Kx/8TUeiYxKjSK 13jLwcRf4iHBec+pcm8jTcDDZaagWge5cekVyTY0= Received: from [10.10.10.3] (149.91.1.15 [149.91.1.15]) by mx.zohomail.com with SMTPS id 168285917183957.9871848963279; Sun, 30 Apr 2023 05:52:51 -0700 (PDT) Message-ID: <4270c379-ae34-0002-e812-874180257d9e@arinc9.com> Date: Sun, 30 Apr 2023 15:52:31 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 2/2] dt-bindings: net: dsa: mediatek,mt7530: document MDIO-bus Content-Language: en-US To: Daniel Golle Cc: David Bauer , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , AngeloGioacchino Del Regno , Landen Chao , DENG Qingfang , Sean Wang , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20230430112834.11520-1-mail@david-bauer.net> <20230430112834.11520-2-mail@david-bauer.net> From: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ZohoMailClient: External Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 30.04.2023 15:44, Daniel Golle wrote: > On Sun, Apr 30, 2023 at 03:34:43PM +0300, Arınç ÜNAL wrote: >> On 30.04.2023 14:28, David Bauer wrote: >>> Document the ability to add nodes for the MDIO bus connecting the >>> switch-internal PHYs. >> >> This is quite interesting. Currently the PHY muxing feature for the MT7530 >> switch looks for some fake ethernet-phy definitions on the mdio-bus where >> the switch is also defined. >> >> Looking at the binding here, there will be an mdio node under the switch >> node. This could be useful to define the ethernet-phys for PHY muxing here >> instead, so we don't waste the register addresses on the parent mdio-bus for >> fake things. It looks like this should work right out of the box. I will do >> some tests. >> >> Are there any examples as to what to configure on the switch PHYs with this >> change? >> >>> >>> Signed-off-by: David Bauer >>> --- >>> .../devicetree/bindings/net/dsa/mediatek,mt7530.yaml | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml >>> index e532c6b795f4..50f8f83cc440 100644 >>> --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml >>> +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml >>> @@ -128,6 +128,12 @@ properties: >>> See Documentation/devicetree/bindings/regulator/mt6323-regulator.txt for >>> details for the regulator setup on these boards. >>> + mdio: >>> + $ref: /schemas/net/mdio.yaml# >>> + unevaluatedProperties: false >>> + description: >>> + Node for the internal MDIO bus connected to the embedded ethernet-PHYs. >> >> Please set this property as false for mediatek,mt7988-switch as it doesn't >> use MDIO. > > Well, quite the opposite is true. This change is **needed** on MT7988 as > the built-in 1GE PHYs of the MT7988 are connected to the (internal) MDIO > bus of the switch. And they do need calibration data assigned as nvmem > via device tree. > > tl;dr: Despite not being connected via MDIO itself also MT7988 exposes an > internal MDIO bus for the switch PHYs. Got it, thanks. Arınç