From: Andrew Lunn <andrew@lunn.ch>
To: "Nerijus Bendžiūnas" <nerijus.bendziunas@gmail.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
regressions@lists.linux.dev, stable@vger.kernel.org
Subject: Re: [PATCH net] net: phy: skip EEE advertisement write when autoneg is disabled
Date: Sat, 16 May 2026 16:23:01 +0200 [thread overview]
Message-ID: <42734eb0-2005-4d6f-b973-9abfeea31bbf@lunn.ch> (raw)
In-Reply-To: <20260516114334.812828-1-nerijus.bendziunas@gmail.com>
> On at least the Broadcom BCM54213PE PHY, however, the indirect MMD
> write triggered from this path while the link is currently forced
> (autoneg off) disturbs the receive datapath
> + /* MMD AN advertisements are only consumed during autoneg. */
> + if (phydev->autoneg == AUTONEG_DISABLE)
> + return 0;
You are not adding this condition because it is not consumed, but
because it is consumed and then bad things happen. Please could you
make the comment accurate.
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2026-05-16 14:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-16 11:43 [PATCH net] net: phy: skip EEE advertisement write when autoneg is disabled Nerijus Bendžiūnas
2026-05-16 14:23 ` Andrew Lunn [this message]
2026-05-16 14:52 ` [PATCH net v2] " Nerijus Bendžiūnas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42734eb0-2005-4d6f-b973-9abfeea31bbf@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=nerijus.bendziunas@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=regressions@lists.linux.dev \
--cc=rmk+kernel@armlinux.org.uk \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox