From: Paulo Marques <pmarques@grupopie.com>
To: Mark Broadbent <markb@wetlettuce.com>
Cc: linux-kernel@vger.kernel.org, jgarzik@pobox.com, netdev@oss.sgi.com
Subject: Re: [PATCH] Tulip interrupt uses non IRQ safe spinlock
Date: Mon, 02 May 2005 15:16:11 +0100 [thread overview]
Message-ID: <4276362B.1010004@grupopie.com> (raw)
In-Reply-To: <E1DRFqC-00028H-Qi@tigger>
Mark Broadbent wrote:
> The interrupt handling code in the tulip network driver appears to use a non
> IRQ safe spinlock in an interrupt context. The following patch should correct
> this.
Huh? Can a network interrupt handler be interrupted by the same interrupt?
AFAIK, the spin_lock_irqsave is to disable interruptions so that an
interrupt can not happen in the critical section, so that the interrupt
handler can not make modifications to shared data. Am I wrong?
--
Paulo Marques - www.grupopie.com
All that is necessary for the triumph of evil is that good men do nothing.
Edmund Burke (1729 - 1797)
next prev parent reply other threads:[~2005-05-02 14:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-28 20:42 [PATCH] Tulip interrupt uses non IRQ safe spinlock Mark Broadbent
2005-04-28 21:26 ` Herbert Xu
2005-04-29 16:35 ` David S. Miller
2005-04-29 17:43 ` Sergey Vlasov
2005-05-02 12:56 ` Mark Broadbent
2005-05-02 21:28 ` Herbert Xu
[not found] ` <57556.192.102.214.6.1115108726.squirrel@webmail.wetlettuce.com>
2005-05-03 9:07 ` Herbert Xu
2005-04-29 18:44 ` Francois Romieu
2005-04-29 22:49 ` Herbert Xu
2005-05-02 12:57 ` Mark Broadbent
2005-05-02 21:31 ` Herbert Xu
[not found] ` <20050502124358.7186447f.davem@davemloft.net>
2005-05-02 21:32 ` Herbert Xu
2005-05-02 21:32 ` David S. Miller
2005-05-02 21:45 ` Herbert Xu
2005-04-30 0:37 ` Alan Cox
2005-04-30 1:02 ` Herbert Xu
2005-05-02 14:16 ` Paulo Marques [this message]
2005-05-28 2:24 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4276362B.1010004@grupopie.com \
--to=pmarques@grupopie.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markb@wetlettuce.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).