From: Patrick McHardy <kaber@trash.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Andrew Morton <akpm@osdl.org>,
netdev@oss.sgi.com, netfilter-devel@lists.netfilter.org
Subject: Re: CONFIG_NETFILTER_DEBUG spew
Date: Mon, 02 May 2005 18:12:47 +0200 [thread overview]
Message-ID: <4276517F.6030606@trash.net> (raw)
In-Reply-To: <20050501111507.GA2133@gondor.apana.org.au>
[-- Attachment #1: Type: text/plain, Size: 175 bytes --]
Herbert Xu wrote:
> BTW, should we do nf_reset in ip_dev_loopback_xmit as well?
I think we should, tc actions could do something unexpected with
the packet.
Regards
Patrick
[-- Attachment #2: x --]
[-- Type: text/plain, Size: 1460 bytes --]
[NETFILTER]: Drop conntrack reference in ip_dev_loopback_xmit()
Signed-off-by: Patrick McHardy <kaber@trash.net>
---
commit c4644e58c8b52dca9699e8ee0e975f5f13eb4d2c
tree 35d8915a3fd6fa39a46d9b2e8e1fd272e82ea3af
parent a91b6fa8bc4b1626d413d58c21cfcfecabbb4a61
author Patrick McHardy <kaber@trash.net> 1115049922 +0200
committer Patrick McHardy <kaber@trash.net> 1115049922 +0200
Index: net/core/netfilter.c
===================================================================
--- 9544bb88b28c2e3ca4b0a66fedfa2bb540ec06e2/net/core/netfilter.c (mode:100644 sha1:92c51824797dd15018e579eb5753cc372e04fd3d)
+++ 35d8915a3fd6fa39a46d9b2e8e1fd272e82ea3af/net/core/netfilter.c (mode:100644 sha1:22a8f127c4aad9821e5f3294aa518807165ee8b7)
@@ -236,8 +236,6 @@
debug_print_hooks_ip(newskb->nf_debug);
nf_dump_skb(PF_INET, newskb);
}
- /* Clear to avoid confusing input check */
- newskb->nf_debug = 0;
}
void nf_debug_ip_finish_output2(struct sk_buff *skb)
Index: net/ipv4/ip_output.c
===================================================================
--- 9544bb88b28c2e3ca4b0a66fedfa2bb540ec06e2/net/ipv4/ip_output.c (mode:100644 sha1:38f69532a029e5ff1ddbdbd665afcff46e94abb5)
+++ 35d8915a3fd6fa39a46d9b2e8e1fd272e82ea3af/net/ipv4/ip_output.c (mode:100644 sha1:24fe3e00b42b0bb673be5a6d8ceb15defb192974)
@@ -111,6 +111,7 @@
#ifdef CONFIG_NETFILTER_DEBUG
nf_debug_ip_loopback_xmit(newskb);
#endif
+ nf_reset(newskb);
netif_rx(newskb);
return 0;
}
next prev parent reply other threads:[~2005-05-02 16:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-01 10:28 CONFIG_NETFILTER_DEBUG spew Andrew Morton
2005-05-01 11:15 ` Herbert Xu
2005-05-01 15:17 ` Patrick McHardy
2005-05-03 23:20 ` David S. Miller
2005-05-05 11:14 ` Harald Welte
2005-05-05 22:36 ` Patrick McHardy
2005-05-02 16:12 ` Patrick McHardy [this message]
2005-05-02 21:36 ` Herbert Xu
2005-05-03 23:20 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4276517F.6030606@trash.net \
--to=kaber@trash.net \
--cc=akpm@osdl.org \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@oss.sgi.com \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).