From: Patrick McHardy <kaber@trash.net>
To: "David S. Miller" <davem@davemloft.net>
Cc: shemminger@osdl.org, netdev@oss.sgi.com, netem@osdl.org
Subject: Re: [PATCH] (3/3) netem: adjust parent qlen when duplicating
Date: Wed, 04 May 2005 01:48:02 +0200 [thread overview]
Message-ID: <42780DB2.2090201@trash.net> (raw)
In-Reply-To: <20050503163025.38bb9682.davem@davemloft.net>
David S. Miller wrote:
> On Wed, 04 May 2005 01:35:29 +0200
> Patrick McHardy <kaber@trash.net> wrote:
>
>>This only works in a hierarchy with just one qdisc above netem, there
>>could be up to seven (check_loop_fn prevents more than that). It's also
>>not safe because it violates qdisc locking rules, when this code is
>>executed dev->queue_lock is already taken and qdisc_lookup() grabs
>>qdisc_tree_lock, but they can only be taken in the other order.
>
> I see... I'm leaving Stephen's patch in there for now.
>
> Perhaps we can create some kind of "propagate up" function
> that will handle all of the parents in the qdisc hierarchy
> above netem?
That's what I already suggested, it should be pretty simple to do
so. I'll send a patch once your tree appears on kernel.org.
BTW, are you pushing it regulary or just for Linus to merge?
Regards
Patrick
next prev parent reply other threads:[~2005-05-03 23:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-03 23:25 [PATCH] (3/3) netem: adjust parent qlen when duplicating Stephen Hemminger
2005-05-03 23:24 ` David S. Miller
2005-05-03 23:35 ` Patrick McHardy
2005-05-03 23:30 ` David S. Miller
2005-05-03 23:48 ` Patrick McHardy [this message]
2005-05-03 23:59 ` David S. Miller
2005-05-04 1:54 ` Patrick McHardy
2005-05-04 1:57 ` Patrick McHardy
2005-05-04 5:01 ` Stephen Hemminger
2005-05-04 17:09 ` [RFC] alternate way of handling netem duplication Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42780DB2.2090201@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=netdev@oss.sgi.com \
--cc=netem@osdl.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).