netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Harald Welte <laforge@netfilter.org>
Cc: netdev@oss.sgi.com, netfilter-devel@lists.netfilter.org,
	Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: CONFIG_NETFILTER_DEBUG spew
Date: Fri, 06 May 2005 00:36:35 +0200	[thread overview]
Message-ID: <427A9FF3.7060408@trash.net> (raw)
In-Reply-To: <20050505111457.GS30482@sunbeam.de.gnumonks.org>

Harald Welte wrote:
> On Sun, May 01, 2005 at 05:17:01PM +0200, Patrick McHardy wrote:
> 
>>You're right. I'm tempted to remove the entire nf_debug stuff,
>>as far as I know it has never found a real bug. But for now
>>I've only fixed the warning.
> 
> 
> yes, I second that change.  At the same time, we should get rid of all
> the lockhelp.h stuff that makes the netfilter code use non-standard lock
> primitives.

I've removed nf_debug. As for lockhelp.h, I'm still undecided whether
I should try to make rwlock debugging a feature of standard rwlocks
or else what to do with all the rwlock assertions.

Regards
Patrick

  reply	other threads:[~2005-05-05 22:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-01 10:28 CONFIG_NETFILTER_DEBUG spew Andrew Morton
2005-05-01 11:15 ` Herbert Xu
2005-05-01 15:17   ` Patrick McHardy
2005-05-03 23:20     ` David S. Miller
2005-05-05 11:14     ` Harald Welte
2005-05-05 22:36       ` Patrick McHardy [this message]
2005-05-02 16:12   ` Patrick McHardy
2005-05-02 21:36     ` Herbert Xu
2005-05-03 23:20     ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=427A9FF3.7060408@trash.net \
    --to=kaber@trash.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=laforge@netfilter.org \
    --cc=netdev@oss.sgi.com \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).