From: Patrick McHardy <kaber@trash.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: davem@davemloft.net, dlstevens@us.ibm.com, laforge@gnumonks.org,
netdev@oss.sgi.com, netfilter-devel@lists.netfilter.org,
pb@bieringer.de, usagi-users@linux-ipv6.org,
yasuyuki.kozakai@toshiba.co.jp, yoshfuji@linux-ipv6.org
Subject: Re: netfilter6: ICMPv6 type 143 doesn't match
Date: Fri, 06 May 2005 16:39:51 +0200 [thread overview]
Message-ID: <427B81B7.2010808@trash.net> (raw)
In-Reply-To: <E1DU2mw-0000UK-00@gondolin.me.apana.org.au>
Herbert Xu wrote:
> Patrick McHardy <kaber@trash.net> wrote:
>>+ err = dev->hard_header(skb, dev, ETH_P_IPV6, ha, NULL, skb->len);
>>+ if (err < 0) {
>>+ IP6_INC_STATS(IPSTATS_MIB_OUTDISCARDS);
>
> You're now incrementing this twice since the callers will also
> increment this.
Thanks, I've removed the line again.
Regards
Patrick
prev parent reply other threads:[~2005-05-06 14:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-25 17:47 netfilter6: ICMPv6 type 143 doesn't match Peter Bieringer
2004-12-27 4:17 ` Yasuyuki Kozakai
2004-12-27 9:02 ` YOSHIFUJI Hideaki / 吉藤英明
2005-01-02 9:12 ` netfilter6: ICMPv6 type 143 doesn't match (130 also not) Peter Bieringer
2005-01-08 11:45 ` (usagi-users 03180) Re: netfilter6: ICMPv6 type 143 doesn't match Peter Bieringer
2005-01-09 17:41 ` (usagi-users 03187) " Peter Bieringer
2005-01-10 13:17 ` (usagi-users 03180) " Olaf Kirch
2005-01-11 19:56 ` (usagi-users 03190) " Peter Bieringer
2005-05-05 19:53 ` Patrick McHardy
2005-05-05 20:20 ` Patrick McHardy
2005-05-05 21:34 ` David S. Miller
2005-05-05 22:26 ` David Stevens
2005-05-05 22:32 ` Patrick McHardy
2005-05-05 22:31 ` David S. Miller
2005-05-05 22:50 ` Patrick McHardy
2005-05-06 13:22 ` Herbert Xu
2005-05-06 14:39 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=427B81B7.2010808@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=dlstevens@us.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=laforge@gnumonks.org \
--cc=netdev@oss.sgi.com \
--cc=netfilter-devel@lists.netfilter.org \
--cc=pb@bieringer.de \
--cc=usagi-users@linux-ipv6.org \
--cc=yasuyuki.kozakai@toshiba.co.jp \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).