From: Patrick McHardy <kaber@trash.net>
To: Asim Shankar <asimshankar@gmail.com>
Cc: netdev@oss.sgi.com
Subject: Re: SFQ: Reordering?
Date: Sat, 07 May 2005 00:07:42 +0200 [thread overview]
Message-ID: <427BEAAE.409@trash.net> (raw)
In-Reply-To: <7bca1cb5050506145344d16b1e@mail.gmail.com>
Asim Shankar wrote:
> Hi,
>
> I was looking through sch_sfq.c. From what I could make out, if the
> perturbation period is non-zero (say Xseconds), then ever X seconds,
> sfq_perturbation() is invoked. This changes the perturbation value
> that will be used by the hash function, however, packets already
> existing in the queue aren't rehashed.
>
> As a result, new packets being enqueued will have a different hash
> value and thus packet re-ordering will take place. I ran a quick test
> using netperf and tcpdump and seem to notice this re-ordering.
>
> Should complete rehashing take place in sfq_perturbation(), or am I
> missing something? (I was looking at 2.6.9 and also took a cursory
> glance at 2.6.11 on lxr.linux.no)
I think we should rehash. Can you send a patch?
Regards
Patrick
next prev parent reply other threads:[~2005-05-06 22:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-06 21:53 SFQ: Reordering? Asim Shankar
2005-05-06 22:07 ` Patrick McHardy [this message]
2005-05-06 22:46 ` Patrick McHardy
2005-05-06 23:02 ` Thomas Graf
2005-05-06 23:19 ` Patrick McHardy
2005-05-07 0:58 ` Thomas Graf
2005-05-07 1:28 ` Patrick McHardy
2005-05-08 11:51 ` Thomas Graf
2005-05-08 16:03 ` Patrick McHardy
2005-05-08 18:33 ` Thomas Graf
2005-05-09 23:14 ` Andy Furniss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=427BEAAE.409@trash.net \
--to=kaber@trash.net \
--cc=asimshankar@gmail.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).