netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: hadi@cyberus.ca
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	netdev <netdev@oss.sgi.com>
Subject: Re: resend patch:  xfrm policybyid
Date: Sun, 08 May 2005 17:23:57 +0200	[thread overview]
Message-ID: <427E2F0D.4040902@trash.net> (raw)
In-Reply-To: <1115562643.19561.148.camel@localhost.localdomain>

jamal wrote:
> On Sun, 2005-08-05 at 18:07 +1000, Herbert Xu wrote:
> 
>>Please elaborate by giving an example of how the index is actually
>>used.  Sorry, but as it is I'm too thick to see your point :)
>
> I have given you enough info that i am concluding this is now becoming a
> debate for the sake of one;->
> 
> Sorry, Herbert, I strongly disagree with your views on this topic. This
> is one of those moments when it becomes obvious there can be no
> compromise. So I am hoping that someone following this discussion or
> writing management apps would speak up.

Allowing the user to freely set indices breaks racoon:

#ifdef __linux__
        /* bsd skips over per-socket policies because there will be no
         * src and dst extensions in spddump messages. On Linux the only
         * way to achieve the same is check for policy id.
         */
        if (xpl->sadb_x_policy_id % 8 >= 3) return 0;
#endif

So how could we handle this?

Regards
Patrick

  reply	other threads:[~2005-05-08 15:23 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-05 13:14 resend patch: xfrm policybyid jamal
2005-05-05 21:32 ` Herbert Xu
2005-05-05 22:17   ` jamal
2005-05-05 22:18     ` David S. Miller
2005-05-06 13:28       ` Herbert Xu
2005-05-06 18:20         ` David S. Miller
2005-05-05 23:12     ` Herbert Xu
2005-05-06  1:15       ` jamal
2005-05-06  1:31         ` Herbert Xu
2005-05-06  2:10           ` jamal
2005-05-06  2:20             ` jamal
2005-05-06  8:54             ` Herbert Xu
2005-05-06 11:53               ` jamal
2005-05-07 10:55                 ` Herbert Xu
2005-05-07 12:38                   ` jamal
2005-05-08  8:07                     ` Herbert Xu
2005-05-08 14:30                       ` jamal
2005-05-08 15:23                         ` Patrick McHardy [this message]
2005-05-08 17:23                           ` jamal
2005-05-09 11:45                             ` Patrick McHardy
2005-05-09 13:10                               ` jamal
2005-05-06 11:04     ` Herbert Xu
2005-05-06 11:56       ` jamal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=427E2F0D.4040902@trash.net \
    --to=kaber@trash.net \
    --cc=davem@davemloft.net \
    --cc=hadi@cyberus.ca \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).