From mboxrd@z Thu Jan 1 00:00:00 1970 From: Quentin Monnet Subject: Re: [PATCH] bpf: Remove unused variable in nsim_bpf Date: Tue, 13 Nov 2018 06:07:08 +0000 Message-ID: <427c8392-ed04-d0bd-76bf-21af79a71eeb@netronome.com> References: <20181112221042.11160-1-natechancellor@gmail.com> <20181112141414.4dacb194@cakuba.netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Alexei Starovoitov , Daniel Borkmann , netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Jakub Kicinski , Nathan Chancellor Return-path: Received: from mail-pl1-f196.google.com ([209.85.214.196]:35265 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726173AbeKMQDm (ORCPT ); Tue, 13 Nov 2018 11:03:42 -0500 Received: by mail-pl1-f196.google.com with SMTP id n4-v6so5477838plp.2 for ; Mon, 12 Nov 2018 22:07:10 -0800 (PST) In-Reply-To: <20181112141414.4dacb194@cakuba.netronome.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: 2018-11-12 14:14 UTC-0800 ~ Jakub Kicinski > On Mon, 12 Nov 2018 15:10:42 -0700, Nathan Chancellor wrote: >> Clang warns: >> >> drivers/net/netdevsim/bpf.c:557:30: error: unused variable 'state' >> [-Werror,-Wunused-variable] >> struct nsim_bpf_bound_prog *state; >> ^ >> 1 error generated. >> >> The declaration should have been removed in commit b07ade27e933 ("bpf: >> pass translate() as a callback and remove its ndo_bpf subcommand"). >> >> Signed-off-by: Nathan Chancellor > > Acked-by: Jakub Kicinski > My bad, thanks for the fix! Acked-by: Quentin Monnet