[PATCH 0/3] add open iscsi netlink interface to iscsi transport class

[PATCH 0/3] add open iscsi netlink interface to iscsi transport class

[Mike Christie]

The following patches add the linux-iscsi-5.X/open-iscsi project's
netlink interface to the iscsi transport class.

Last time I messed up and did not inline the patches so the reason for
the allignment in some structures was not clear. There was also a bug in
that unsigned long was being used instead of u64/unit64_t so that
complicated matters. We have been discussing this internally but I am
not sure I know the best route - I had hoped to just be able to remove
them all like was suggested, so I am reposting the patches inlined with
hopefully at least Chris Wright and almost all of Christoph Hellwig's
comments addressed.

The one suggestion we were not able to complete was the one to move the
scsi_remove_host and scsi_host_add calls. It is trivial to do, but
seemed odd since every iscsi_transport would need to add these calls. I
can understand in the future when HW iSCSI is supported all our
scsi_host lifetime code will need to be reworked because they allocate a
host per pci device and we allocate a host per session (maybe a common
place to meet would be a host per initiator port), but with only
software iSCSI supported today maybe a little more info is needed. Is
the suggestion to move the add/remove host calls to the iscsi_transport
to allow the transport to control when they want to begin queueing comamnds?

Maybe the removal of ISCSI_TRANSPORT_MAX is also not completely met too.
I am hoping to finish fixing that by exposing the same information
through sysfs, but I am still trying to figure out how the layout should
be implmented using the driver model transport classes and struct
devices or kobjects or whatever makes people happy. We could simply do 
this using driver model transport classes by just adding a 
iscsi_transport class that represents the iSCSI transport like 
iscsi_tcp, iscsi_iser and making that the parent of the session, but 
maybe that is better done in a seperate patch so we can discuss the 
abstraction for the parent of the session seperately.

More info about the open-iscsi/linux-iscsi-5 project can found here
http://open-iscsi.org/.

Patches

1. add-iscsi-netlink-def.patch - include/linux/netlink.h changes (added
new protocol NETLINK_ISCSI)

2.  common-iscsi-headers.patch - Common header files:
  - iscsi_if.h (user/kernel #defines);
  - iscsi_proto.h (RFC3720 #defines and types);
  - iscsi_ifev.h (user/kernel events).

3. integrate-iscsi-netlink.patch - incorporate the
open-iscsi/linux-iscsi netlink interface into the iscsi transport class.


Thanks,

Linux-iscsi Team

[PATCH 0/3] add open iscsi netlink interface to iscsi transport class

[Mike Christie]

The following patches add the linux-iscsi-5.X/open-iscsi project's 
netlink interface to the iscsi transport class since the groups doing 
iSCSI over TCP (this module is completed now and will be submitted in a 
seperate mail), iSCSI over SCTP and iSER are using it for a common 
interface and to share code.

The answers to why netlink and why push so much to userspace can be 
found here http://open-iscsi.org/.

Patches

1. add-iscsi-netlink-def.patch - include/linux/netlink.h changes (added 
new protocol NETLINK_ISCSI)

2.  common-iscsi-headers.patch - Common header files:
  - iscsi_if.h (user/kernel #defines);
  - iscsi_proto.h (RFC3720 #defines and types);
  - iscsi_ifev.h (user/kernel events).

3. integrate-iscsi-netlink.patch - incorporate the 
open-iscsi/linux-iscsi netlink interface into the iscsi transport class.


Thanks,

Linux-iscsi Team