* [PATCH 1/4] iseries_veth: Don't send packets to LPARs which aren't up
@ 2005-05-12 7:47 Michael Ellerman
2005-05-15 22:08 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Michael Ellerman @ 2005-05-12 7:47 UTC (permalink / raw)
To: Andrew Morton, Jeff Garzik; +Cc: netdev, linux-kernel
Hi Andrew, Jeff,
The iseries_veth driver has a logic bug which means it will erroneously
send packets to LPARs for which we don't have a connection.
This usually isn't a big problem because the Hypervisor call fails
gracefully and we return, but if packets are TX'ed during the negotiation
of the connection bad things might happen.
Regardless, the right thing is to bail early if we know there's no
connection.
Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
--
iseries_veth.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
Index: veth-fixes/drivers/net/iseries_veth.c
===================================================================
--- veth-fixes.orig/drivers/net/iseries_veth.c
+++ veth-fixes/drivers/net/iseries_veth.c
@@ -924,7 +924,7 @@ static int veth_transmit_to_one(struct s
spin_lock_irqsave(&cnx->lock, flags);
- if (! cnx->state & VETH_STATE_READY)
+ if (! (cnx->state & VETH_STATE_READY))
goto drop;
if ((skb->len - 14) > VETH_MAX_MTU)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-05-15 22:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-05-12 7:47 [PATCH 1/4] iseries_veth: Don't send packets to LPARs which aren't up Michael Ellerman
2005-05-15 22:08 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).