Fw: [Bugme-new] [Bug 4482] New: natsemi: incorrect initialization of IPv6 Neighbor-discovery multicast

Fw: [Bugme-new] [Bug 4482] New: natsemi: incorrect initialization of IPv6 Neighbor-discovery multicast

[Andrew Morton]

Begin forwarded message:

Date: Wed, 13 Apr 2005 07:19:38 -0700
From: bugme-daemon@osdl.org
To: bugme-new@lists.osdl.org
Subject: [Bugme-new] [Bug 4482] New: natsemi: incorrect initialization of IPv6 Neighbor-discovery multicast


http://bugme.osdl.org/show_bug.cgi?id=4482

           Summary: natsemi: incorrect initialization of IPv6 Neighbor-
                    discovery multicast
    Kernel Version: 2.6.11.7
            Status: NEW
          Severity: normal
             Owner: jgarzik@pobox.com
         Submitter: svallet@gmail.com


Distribution: Debian Sarge (testing)

Hardware Environment: 
Arch is PowerPC/BeigeG3
Problematic NIC has a DP83815 chipset (Netgear FA311)

Software Environment:
iproute2/ifconfig

Problem Description:
"ifconfig eth0 up" *apparently* allows multicast on the device :
# ifconfig eth0
...
UP BROADCAST RUNNING MULTICAST
...

# ip maddr show
...
1:   eth0
     link   33:33:ff:be:0a:ed
     link   33:33:00:00:00:01
     ...
     inet6  ff02::1:ffbe:aed
     inet6  ff02::1

However, the NIC does *not* reply to neighbor-sollicitation multicasts, neither
on 33:33:00:00:00:01 (ping6 ff02::1) or on the sollicited-node multicast.

It *is* however responding *after* being brought in promiscuous mode (using
tcpdump) or an "ifconfig eth0 multicast" has been issued. Shuting down and up
brings the problem back again


Steps to reproduce:
# ifconfig eth0 down
# ifconfig eth0 up

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

Re: Fw: [Bugme-new] [Bug 4482] New: natsemi: incorrect initialization of IPv6 Neighbor-discovery multicast

[Herbert Xu]

[-- Attachment #1: Type: text/plain, Size: 798 bytes --]

On Wed, Apr 13, 2005 at 05:36:42PM +0000, Andrew Morton wrote:
> 
>            Summary: natsemi: incorrect initialization of IPv6 Neighbor-
>                     discovery multicast

I've got a pair of FA312 cards and this problem has bothered me
for ages.  This has finally prompted me to do something about it :)

Turns out that somebody wasn't following the documentation.  We were
doing 16-bit writes to 32-bit registers which led to some addresses
working and others not so lucky.

This patch should fix the problem.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[-- Attachment #2: natsemi-1 --]
[-- Type: text/plain, Size: 621 bytes --]

===== drivers/net/natsemi.c 1.74 vs edited =====
--- 1.74/drivers/net/natsemi.c	2005-03-03 16:00:42 +11:00
+++ edited/drivers/net/natsemi.c	2005-04-16 16:20:29 +10:00
@@ -2433,9 +2433,9 @@
 		rx_mode = RxFilterEnable | AcceptBroadcast
 			| AcceptMulticast | AcceptMyPhys;
 		for (i = 0; i < 64; i += 2) {
-			writew(HASH_TABLE + i, ioaddr + RxFilterAddr);
-			writew((mc_filter[i+1]<<8) + mc_filter[i],
-				ioaddr + RxFilterData);
+			writel(HASH_TABLE + i, ioaddr + RxFilterAddr);
+			writel((mc_filter[i + 1] << 8) + mc_filter[i],
+			       ioaddr + RxFilterData);
 		}
 	}
 	writel(rx_mode, ioaddr + RxFilterAddr);

Re: Fw: [Bugme-new] [Bug 4482] New: natsemi: incorrect initialization of IPv6 Neighbor-discovery multicast

[Jeff Garzik]

applied