From: Jeff Garzik <jgarzik@pobox.com>
To: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH] reduce stack usage for arlan
Date: Sun, 15 May 2005 23:22:35 -0400 [thread overview]
Message-ID: <428811FB.1050308@pobox.com> (raw)
In-Reply-To: <20050308153457.GB8703@wohnheim.fh-wedel.de>
Jörn Engel wrote:
> Jean Tourrilhes indicated that this driver is currently unmaintained.
> Jeff, do you want this patch?
> #define SARLSTR(var,nn) {\
> - char tmpStr[400];\
> + char tmpStr[50];\
> int tmpLn = nn;\
> - if (nn > 399 ) tmpLn = 399; \
> + BUG_ON(tmpLn > 49);\
I'm uncomfortable with arbitrarily lowering the string size, even if it
does include a BUG_ON()...
Jeff
next prev parent reply other threads:[~2005-05-16 3:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-08 15:34 [PATCH] reduce stack usage for arlan Jörn Engel
2005-05-16 3:22 ` Jeff Garzik [this message]
2005-05-18 12:20 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=428811FB.1050308@pobox.com \
--to=jgarzik@pobox.com \
--cc=joern@wohnheim.fh-wedel.de \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).