From: Jeff Garzik <jgarzik@pobox.com>
To: akpm@osdl.org
Cc: T-Bone@parisc-linux.org, grundler@parisc-linux.org,
varenet@parisc-linux.org,
Linux Kernel <linux-kernel@vger.kernel.org>,
Netdev <netdev@oss.sgi.com>
Subject: Re: patch tulip-natsemi-dp83840a-phy-fix.patch added to -mm tree
Date: Mon, 16 May 2005 00:06:48 -0400 [thread overview]
Message-ID: <42881C58.40001@pobox.com> (raw)
In-Reply-To: <200505101955.j4AJtX9x032464@shell0.pdx.osdl.net>
akpm@osdl.org wrote:
> +
> + /* flush posted writes */
> + ioread32(ioaddr + CSR15);
> +
> + /* Sect 3.10.3 in DP83840A.pdf (p39) */
> + udelay(500);
> +
> + /* Section 4.2 in DP83840A.pdf (p43) */
> + /* and IEEE 802.3 "22.2.4.1.1 Reset" */
> + while (timeout-- &&
> + (tulip_mdio_read (dev, phy_num, MII_BMCR) & BMCR_RESET))
> + udelay(100);
Note that while the patch creates the correct behavior, the delays above
occur inside spin_lock_irqsave() and/or timer context.
I have been to get HP to fix this patch's delay problem for -years-.
Jeff
next parent reply other threads:[~2005-05-16 4:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200505101955.j4AJtX9x032464@shell0.pdx.osdl.net>
2005-05-16 4:06 ` Jeff Garzik [this message]
2005-05-16 5:08 ` patch tulip-natsemi-dp83840a-phy-fix.patch added to -mm tree Grant Grundler
2005-05-16 16:46 ` Jeff Garzik
2005-05-16 22:26 ` Grant Grundler
2005-05-20 18:58 ` Jeff Garzik
2005-05-20 19:15 ` Francois Romieu
2005-05-20 21:12 ` Grant Grundler
2005-05-20 21:34 ` Jeff Garzik
2005-05-21 0:51 ` Grant Grundler
2005-05-21 22:39 ` Francois Romieu
2005-05-22 4:56 ` Grant Grundler
2005-05-27 2:16 ` Jeff Garzik
2005-05-27 7:17 ` Francois Romieu
2005-10-04 13:18 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42881C58.40001@pobox.com \
--to=jgarzik@pobox.com \
--cc=T-Bone@parisc-linux.org \
--cc=akpm@osdl.org \
--cc=grundler@parisc-linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=varenet@parisc-linux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).