* [NET] 2.6.x build warning
@ 2005-05-26 19:09 Jeff Garzik
2005-05-26 23:06 ` David S. Miller
2005-05-27 0:54 ` YOSHIFUJI Hideaki / 吉藤英明
0 siblings, 2 replies; 3+ messages in thread
From: Jeff Garzik @ 2005-05-26 19:09 UTC (permalink / raw)
To: Netdev
from current git tree:
net/ipv6/ip6_flowlabel.c: In function `ipv6_flowlabel_opt':
net/ipv6/ip6_flowlabel.c:540: warning: ignoring return value of
`copy_to_user', declared with attribute warn_unused_result
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [NET] 2.6.x build warning
2005-05-26 19:09 [NET] 2.6.x build warning Jeff Garzik
@ 2005-05-26 23:06 ` David S. Miller
2005-05-27 0:54 ` YOSHIFUJI Hideaki / 吉藤英明
1 sibling, 0 replies; 3+ messages in thread
From: David S. Miller @ 2005-05-26 23:06 UTC (permalink / raw)
To: jgarzik; +Cc: netdev
From: Jeff Garzik <jgarzik@pobox.com>
Date: Thu, 26 May 2005 15:09:15 -0400
> from current git tree:
>
> net/ipv6/ip6_flowlabel.c: In function `ipv6_flowlabel_opt':
> net/ipv6/ip6_flowlabel.c:540: warning: ignoring return value of
> `copy_to_user', declared with attribute warn_unused_result
I've fixed this warning in my tree, thanks Jeff.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [NET] 2.6.x build warning
2005-05-26 19:09 [NET] 2.6.x build warning Jeff Garzik
2005-05-26 23:06 ` David S. Miller
@ 2005-05-27 0:54 ` YOSHIFUJI Hideaki / 吉藤英明
1 sibling, 0 replies; 3+ messages in thread
From: YOSHIFUJI Hideaki / 吉藤英明 @ 2005-05-27 0:54 UTC (permalink / raw)
To: davem, jgarzik; +Cc: netdev, yoshfuji
In article <42961EDB.7000407@pobox.com> (at Thu, 26 May 2005 15:09:15 -0400), Jeff Garzik <jgarzik@pobox.com> says:
> from current git tree:
>
> net/ipv6/ip6_flowlabel.c: In function `ipv6_flowlabel_opt':
> net/ipv6/ip6_flowlabel.c:540: warning: ignoring return value of
> `copy_to_user', declared with attribute warn_unused_result
As before, it is intentional.
Okay, let's just waste the result for avoiding the warning.
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Index: net/ipv6/ip6_flowlabel.c
===================================================================
--- 30b3bda5e47d088b46ab8eab4d69d059a71197e1/net/ipv6/ip6_flowlabel.c (mode:100644)
+++ uncommitted/net/ipv6/ip6_flowlabel.c (mode:100644)
@@ -535,10 +535,11 @@
if (err)
goto done;
- /* Do not check for fault */
- if (!freq.flr_label)
- copy_to_user(&((struct in6_flowlabel_req __user *) optval)->flr_label,
- &fl->label, sizeof(fl->label));
+ if (!freq.flr_label) {
+ /* Do not check for fault */
+ int dummy = copy_to_user(&((struct in6_flowlabel_req __user *) optval)->flr_label,
+ &fl->label, sizeof(fl->label));
+ }
sfl1->fl = fl;
sfl1->next = np->ipv6_fl_list;
--
YOSHIFUJI Hideaki @ USAGI Project <yoshfuji@linux-ipv6.org>
GPG-FP : 9022 65EB 1ECF 3AD1 0BDF 80D8 4807 F894 E062 0EEA
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-05-27 0:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-05-26 19:09 [NET] 2.6.x build warning Jeff Garzik
2005-05-26 23:06 ` David S. Miller
2005-05-27 0:54 ` YOSHIFUJI Hideaki / 吉藤英明
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).