From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Schmidt Subject: Re: [PATCH] ieee802154: remove a redundant local variable 'i' Date: Thu, 27 Sep 2018 16:47:32 +0200 Message-ID: <42999ee5-20c2-5d2c-4ca3-e5bb8f5a3864@datenfreihafen.org> References: <1537368097-60101-1-git-send-email-zhongjiang@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: alex.aring@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: zhong jiang , davem@davemloft.net Return-path: In-Reply-To: <1537368097-60101-1-git-send-email-zhongjiang@huawei.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hello. On 19/09/2018 16:41, zhong jiang wrote: > The local variable 'i' is never used after being assigned. > hence it should be redundant adn can be removed. > > Signed-off-by: zhong jiang > --- > net/ieee802154/nl802154.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/net/ieee802154/nl802154.c b/net/ieee802154/nl802154.c > index 99f6c25..5b90151 100644 > --- a/net/ieee802154/nl802154.c > +++ b/net/ieee802154/nl802154.c > @@ -445,7 +445,6 @@ static int nl802154_send_wpan_phy(struct cfg802154_registered_device *rdev, > { > struct nlattr *nl_cmds; > void *hdr; > - int i; > > hdr = nl802154hdr_put(msg, portid, seq, flags, cmd); > if (!hdr) > @@ -508,7 +507,6 @@ static int nl802154_send_wpan_phy(struct cfg802154_registered_device *rdev, > if (!nl_cmds) > goto nla_put_failure; > > - i = 0; > #define CMD(op, n) \ > do { \ > if (rdev->ops->op) { \ > Sorry, but this patch is wrong. The variable i is used in line 513 inside the CMD() macro. The compiler clearly tells this when running with your patch: net/ieee802154/nl802154.c: In function ‘nl802154_send_wpan_phy’: net/ieee802154/nl802154.c:513:4: error: ‘i’ undeclared (first use in this function) I would appreciate if patches sent out would at least be compile tested. regards Stefan Schmidt