From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Wang Subject: Re: [PATCH net-next V3] virtio_net: ethtool tx napi configuration Date: Thu, 11 Oct 2018 17:47:19 +0800 Message-ID: <429a1196-b1a1-42ff-4dbb-b3e1b35c6652@redhat.com> References: <20181009020626.31723-1-jasowang@redhat.com> <20181010.223458.915344551656019248.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Cc: mst@redhat.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, willemb@google.com To: David Miller Return-path: Received: from mx1.redhat.com ([209.132.183.28]:54956 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726205AbeJKROA (ORCPT ); Thu, 11 Oct 2018 13:14:00 -0400 In-Reply-To: <20181010.223458.915344551656019248.davem@davemloft.net> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 2018年10月11日 13:34, David Miller wrote: > From: Jason Wang > Date: Tue, 9 Oct 2018 10:06:26 +0800 > >> Implement ethtool .set_coalesce (-C) and .get_coalesce (-c) handlers. >> Interrupt moderation is currently not supported, so these accept and >> display the default settings of 0 usec and 1 frame. >> >> Toggle tx napi through setting tx-frames. So as to not interfere >> with possible future interrupt moderation, value 1 means tx napi while >> value 0 means not. >> >> Only allow the switching when device is down for simplicity. >> >> Link: https://patchwork.ozlabs.org/patch/948149/ >> Suggested-by: Jason Wang >> Signed-off-by: Willem de Bruijn >> Signed-off-by: Jason Wang >> --- >> Changes from V2: >> - only allow the switching when device is done >> - remove unnecessary global variable and initialization >> Changes from V1: >> - try to synchronize with datapath to allow changing mode when >> interface is up. >> - use tx-frames 0 as to disable tx napi while tx-frames 1 to enable tx napi > Applied, with... > >> + bool running = netif_running(dev); > this unused variable removed. My bad, thanks for the fixup.