From: Jeff Garzik <jgarzik@pobox.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>,
James Morris <jmorris@redhat.com>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
netdev@oss.sgi.com
Subject: Re: [RFC] Replace scatterlist with crypto_frag
Date: Fri, 03 Jun 2005 20:02:52 -0400 [thread overview]
Message-ID: <42A0EFAC.7070609@pobox.com> (raw)
In-Reply-To: <20050603234623.GA20088@gondor.apana.org.au>
Herbert Xu wrote:
> The Crypto API doesn't need all the data contained in a scatterlist
> structure. For instance, it has no need for anything to do with DMA.
> When we implement hardware crypto (which might do DMA), they're going
> to have their own lists of descriptors so they can't use the scatterlist
> as is anyway.
I'm not sure I agree with this.
A standard feature of struct scatterlist is having the DMA mappings
right next to the kernel virtual address/length info. Drivers use the
arch-specific DMA-mapped part of struct scatterlist to fill the
hardware-specific descriptions with addresses and other info.
Since you -will- have to DMA map buffers before passing them to
hardware, it seems like struct scatterlist is much more appropriate than
crypto_frag when dealing with hardware.
For pure software implementations, I don't see why you can't just ignore
the extra fields that each arch puts into struct scatterlist.
Jeff
next prev parent reply other threads:[~2005-06-04 0:02 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-03 23:46 [RFC] Replace scatterlist with crypto_frag Herbert Xu
2005-06-04 0:02 ` Jeff Garzik [this message]
2005-06-04 0:42 ` Herbert Xu
2005-06-04 4:39 ` James Morris
2005-06-04 4:51 ` Herbert Xu
2005-06-04 5:23 ` James Morris
2005-06-04 5:33 ` Herbert Xu
2005-06-04 10:00 ` Evgeniy Polyakov
2005-06-04 9:55 ` Evgeniy Polyakov
2005-06-04 9:58 ` Herbert Xu
2005-06-04 10:17 ` Evgeniy Polyakov
2005-06-04 10:22 ` Herbert Xu
2005-06-04 10:29 ` Evgeniy Polyakov
2005-06-04 10:32 ` Herbert Xu
2005-06-04 10:40 ` Evgeniy Polyakov
2005-06-06 22:36 ` David S. Miller
2005-06-04 11:23 ` Christoph Hellwig
2005-06-04 11:26 ` Herbert Xu
2005-06-04 11:58 ` Christoph Hellwig
2005-06-06 11:59 ` Herbert Xu
2005-06-06 12:09 ` Christoph Hellwig
2005-06-06 12:40 ` Herbert Xu
2005-06-06 13:30 ` Christoph Hellwig
2005-06-06 22:46 ` David S. Miller
2005-06-06 23:04 ` Herbert Xu
2005-06-06 23:09 ` David S. Miller
2005-06-06 23:14 ` Herbert Xu
2005-06-06 23:18 ` David S. Miller
2005-06-06 23:20 ` Herbert Xu
2005-06-06 23:05 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42A0EFAC.7070609@pobox.com \
--to=jgarzik@pobox.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jmorris@redhat.com \
--cc=linux-crypto@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).