netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: James Ketrenos <jketreno@linux.intel.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: pavel@ucw.cz, vda@ilport.com.ua, abonilla@linuxwireless.org,
	jgarzik@pobox.com, netdev@oss.sgi.com,
	linux-kernel@vger.kernel.org, ipw2100-admin@linux.intel.com
Subject: Re: ipw2100: firmware problem
Date: Thu, 09 Jun 2005 16:01:30 -0500	[thread overview]
Message-ID: <42A8AE2A.4080104@linux.intel.com> (raw)
In-Reply-To: <20050609.125324.88476545.davem@davemloft.net>

David S. Miller wrote:

>From: Pavel Machek <pavel@ucw.cz>
>Date: Thu, 9 Jun 2005 12:42:05 +0200
>
>  
>
>>I'm not saying it should not work automagically. But it is wrong to
>>start transmitting on wireless as soon as kernel boots. It should stay
>>quiet in the radio until it is either told to talk or until interface
>>is upped.
>>    
>>
>
>I agree.
>
>There is a similar problem in the Acenic driver, it brings the
>link up and receives broadcast packets as soon as the driver
>is loaded.  Mostly this is because the driver inits the chip
>and registers the IRQ handler at probe time, whereas nearly
>every other driver does this at ->open() time.
>  
>
The ipw2100 originally postponed doing any initialization until open was
called.  The problem at that time was that distributions were crafted to
rely on link detection (I believe via ethtoolop's get_link) before they
would bring the interface up.

With a wireless device, you don't have link until you are associated... 
chicken and egg.  The solution was to move initialization and
association to the probe.

I don't know if all the distributions have moved away from this model. 
If they have and the devices are brought up regardless of link, then
going back to delaying radio initialization until the open() is called
is workable. 

James

  reply	other threads:[~2005-06-09 21:01 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-08 14:23 ipw2100: firmware problem Pavel Machek
2005-06-08 14:44 ` Denis Vlasenko
2005-06-08 14:56   ` Jirka Bohac
2005-06-08 16:29     ` Pavel Machek
2005-06-21  7:42     ` Simon Kelley
2005-06-21  8:29       ` Feyd
2005-06-21  8:46         ` Simon Kelley
2005-06-08 15:05   ` Alejandro Bonilla
2005-06-08 15:23     ` Jiri Benc
2005-06-09  6:09     ` Denis Vlasenko
2005-06-09  6:16       ` David S. Miller
2005-06-09  6:25         ` Denis Vlasenko
2005-06-09  6:28           ` David S. Miller
2005-06-09  6:37             ` Denis Vlasenko
2005-06-09  8:36               ` Wichert Akkerman
2005-06-09 10:42         ` Pavel Machek
2005-06-09 19:53           ` David S. Miller
2005-06-09 21:01             ` James Ketrenos [this message]
2005-06-09 21:11               ` Pavel Machek
2005-06-09 21:15               ` Arjan van de Ven
2005-06-09 22:11               ` David S. Miller
2005-06-10  2:13               ` Jeff Garzik
2005-06-10  2:46                 ` Alejandro Bonilla
2005-06-10  9:00                   ` Pavel Machek
2005-06-10 13:00                     ` John Stoffel
2005-06-10 13:33                     ` Alejandro Bonilla
2005-06-09 14:31       ` Alejandro Bonilla
2005-06-10  6:56         ` Denis Vlasenko
2005-06-10 13:23           ` Alejandro Bonilla
2005-06-10 20:26             ` Lee Revell
2005-06-10 21:00               ` Alejandro Bonilla
2005-06-10 21:07                 ` Lee Revell
2005-06-13 16:42               ` Jan Rychter
2005-06-11 12:44             ` Denis Vlasenko
2005-06-08 17:10   ` James Ketrenos
2005-06-08 19:43     ` David S. Miller
2005-06-08 19:49       ` Dave Jones
2005-06-08 19:54         ` David S. Miller
2005-06-09  6:03       ` Denis Vlasenko
2005-06-09  6:10         ` David S. Miller
2005-06-09  6:17           ` Denis Vlasenko
2005-06-09  6:20             ` David S. Miller
2005-06-09  6:30               ` Denis Vlasenko
2005-06-09  6:35                 ` David S. Miller
2005-06-10  3:51                 ` Jim Crilly
2005-06-09  6:06       ` Jeff Garzik
2005-06-09  6:13         ` David S. Miller
2005-06-09  6:29           ` Jeff Garzik
2005-06-08 16:58 ` James Ketrenos
2005-06-08 21:27   ` Pavel Machek
2005-06-08 21:46     ` James Ketrenos
2005-06-08 22:34       ` Pavel Machek
2005-06-09  3:33         ` Zhu Yi
2005-06-09 10:56           ` Pavel Machek
2005-06-09 13:56   ` Andi Kleen
2005-06-09 21:12     ` Olivier Galibert
2005-06-09 23:13       ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42A8AE2A.4080104@linux.intel.com \
    --to=jketreno@linux.intel.com \
    --cc=abonilla@linuxwireless.org \
    --cc=davem@davemloft.net \
    --cc=ipw2100-admin@linux.intel.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    --cc=pavel@ucw.cz \
    --cc=vda@ilport.com.ua \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).