From: Eric Dumazet <dada1@cosmosbay.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@oss.sgi.com
Subject: [PATCH] dont use strlen() but the result from a prior sprintf()
Date: Wed, 22 Jun 2005 14:56:55 +0200 [thread overview]
Message-ID: <42B96017.1050803@cosmosbay.com> (raw)
In-Reply-To: <20050621.165634.07642938.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 769 bytes --]
Hi David
Small patch to save an unecessary call to strlen() : sprintf() gave us the length, just trust it.
Thank you
Eric Dumazet
diff -Nu linux-2.6.12-orig/net/socket.c linux-2.6.12/net/socket.c
--- linux-2.6.12-orig/net/socket.c 2005-06-22 14:47:56.000000000 +0200
+++ linux-2.6.12/net/socket.c 2005-06-22 14:49:22.000000000 +0200
@@ -382,9 +382,8 @@
goto out;
}
- sprintf(name, "[%lu]", SOCK_INODE(sock)->i_ino);
+ this.len = sprintf(name, "[%lu]", SOCK_INODE(sock)->i_ino);
this.name = name;
- this.len = strlen(name);
this.hash = SOCK_INODE(sock)->i_ino;
file->f_dentry = d_alloc(sock_mnt->mnt_sb->s_root, &this);
[-- Attachment #2: patch.1 --]
[-- Type: text/plain, Size: 446 bytes --]
--- linux-2.6.12-orig/net/socket.c 2005-06-22 14:47:56.000000000 +0200
+++ linux-2.6.12/net/socket.c 2005-06-22 14:49:22.000000000 +0200
@@ -382,9 +382,8 @@
goto out;
}
- sprintf(name, "[%lu]", SOCK_INODE(sock)->i_ino);
+ this.len = sprintf(name, "[%lu]", SOCK_INODE(sock)->i_ino);
this.name = name;
- this.len = strlen(name);
this.hash = SOCK_INODE(sock)->i_ino;
file->f_dentry = d_alloc(sock_mnt->mnt_sb->s_root, &this);
prev parent reply other threads:[~2005-06-22 12:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <B1508D50A0692F42B217C22C02D84972067F0805@NT-IRVA-0741.brcm.ad.broadcom.com>
2005-06-14 15:46 ` [PATCH] tg3_msi() and weakly ordered memory Grant Grundler
[not found] ` <1118771563.7059.30.camel@rh4>
[not found] ` <20050614211530.GB25516@esmail.cup.hp.com>
2005-06-21 23:56 ` David S. Miller
2005-06-22 5:20 ` Grant Grundler
2005-06-22 12:56 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42B96017.1050803@cosmosbay.com \
--to=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).