From: Patrick McHardy <kaber@trash.net>
To: Thomas Graf <tgraf@suug.ch>
Cc: Harald Welte <laforge@netfilter.org>,
netdev@vger.kernel.org, Jamal Hadi Salim <hadi@cyberus.ca>,
Netfilter Development Mailinglist
<netfilter-devel@lists.netfilter.org>,
Pablo Neira <pablo@eurodev.net>
Subject: Re: [PATCH 1/2] updates for [nf|ct]netlink and event API
Date: Thu, 30 Jun 2005 15:27:55 +0200 [thread overview]
Message-ID: <42C3F35B.50805@trash.net> (raw)
In-Reply-To: <20050630120302.GI16076@postel.suug.ch>
Thomas Graf wrote:
> Good point, after all, I think structs have been used too often
> and we now suffer from backwards compatbility issues. The
> points likely to be argueable are things like trim responsibility
> in the error handling, i.e. delegate it down to the function
> which also created the header or trim on every level. Other than
> that the whole thing should be pretty straight forward.
I think for nested attributes error handling should happen on the
outer level. Just trimming on the inner level would leave a
half-finished nested attribute.
> What do you think about naming it nlattr?
Sounds good.
Regards
Patrick
next prev parent reply other threads:[~2005-06-30 13:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <42C03F2E.30706@eurodev.net>
[not found] ` <42C0806E.3010400@trash.net>
[not found] ` <20050628071308.GE13239@sunbeam.de.gnumonks.org>
[not found] ` <42C1747A.3010703@trash.net>
[not found] ` <42C2F2DF.7070301@eurodev.net>
[not found] ` <42C2FC14.80609@trash.net>
[not found] ` <42C33E33.7090908@eurodev.net>
[not found] ` <42C34445.9020709@trash.net>
[not found] ` <20050630014901.GH16076@postel.suug.ch>
[not found] ` <42C350A1.1030602@trash.net>
2005-06-30 12:03 ` [PATCH 1/2] updates for [nf|ct]netlink and event API Thomas Graf
2005-06-30 13:27 ` Patrick McHardy [this message]
2005-06-30 18:02 ` Thomas Graf
2005-06-30 21:26 ` Patrick McHardy
2005-06-30 21:34 ` Thomas Graf
2005-06-30 21:49 ` David S. Miller
2005-06-30 22:08 ` Thomas Graf
2005-06-30 22:08 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42C3F35B.50805@trash.net \
--to=kaber@trash.net \
--cc=hadi@cyberus.ca \
--cc=laforge@netfilter.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@lists.netfilter.org \
--cc=pablo@eurodev.net \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).