From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH 1/2] updates for [nf|ct]netlink and event API Date: Thu, 30 Jun 2005 15:27:55 +0200 Message-ID: <42C3F35B.50805@trash.net> References: <42C03F2E.30706@eurodev.net> <42C0806E.3010400@trash.net> <20050628071308.GE13239@sunbeam.de.gnumonks.org> <42C1747A.3010703@trash.net> <42C2F2DF.7070301@eurodev.net> <42C2FC14.80609@trash.net> <42C33E33.7090908@eurodev.net> <42C34445.9020709@trash.net> <20050630014901.GH16076@postel.suug.ch> <42C350A1.1030602@trash.net> <20050630120302.GI16076@postel.suug.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: Harald Welte , netdev@vger.kernel.org, Jamal Hadi Salim , Netfilter Development Mailinglist , Pablo Neira Return-path: To: Thomas Graf In-Reply-To: <20050630120302.GI16076@postel.suug.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: netfilter-devel-bounces@lists.netfilter.org Errors-To: netfilter-devel-bounces@lists.netfilter.org List-Id: netdev.vger.kernel.org Thomas Graf wrote: > Good point, after all, I think structs have been used too often > and we now suffer from backwards compatbility issues. The > points likely to be argueable are things like trim responsibility > in the error handling, i.e. delegate it down to the function > which also created the header or trim on every level. Other than > that the whole thing should be pretty straight forward. I think for nested attributes error handling should happen on the outer level. Just trimming on the inner level would leave a half-finished nested attribute. > What do you think about naming it nlattr? Sounds good. Regards Patrick