From: Jeff Garzik <jgarzik@pobox.com>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: Netdev <netdev@oss.sgi.com>, Ayaz Abdulla <AAbdulla@nvidia.com>
Subject: Re: [PATCH] forcedeth: Add support for 64-bit dma addresses.
Date: Fri, 22 Jul 2005 16:56:35 -0400 [thread overview]
Message-ID: <42E15D83.7000902@pobox.com> (raw)
In-Reply-To: <42E15AE7.3020304@colorfullife.com>
Manfred Spraul wrote:
> + if (id->driver_data & DEV_HAS_HIGH_DMA) {
> + np->desc_ver = DESC_VER_3;
> + dev->features |= NETIF_F_HIGHDMA;
> + if (pci_set_dma_mask(pci_dev, 0x0000007fffffffffULL)) {
> + if (pci_set_dma_mask(pci_dev, 0xffffffffULL))
> + goto out_relreg;
> + }
setting of NETIF_F_HIGHDMA is wrong, if 64-bit set-dma-mask fails.
next prev parent reply other threads:[~2005-07-22 20:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-22 20:45 [PATCH] forcedeth: Add support for 64-bit dma addresses Manfred Spraul
2005-07-22 20:56 ` Jeff Garzik [this message]
2005-07-22 21:09 ` Manfred Spraul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42E15D83.7000902@pobox.com \
--to=jgarzik@pobox.com \
--cc=AAbdulla@nvidia.com \
--cc=manfred@colorfullife.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).