* [-mm patch] include/net/ieee80211.h must #include <linux/wireless.h>
@ 2005-07-22 21:39 Adrian Bunk
0 siblings, 0 replies; 4+ messages in thread
From: Adrian Bunk @ 2005-07-22 21:39 UTC (permalink / raw)
To: jgarzik, jkmaline, hostap; +Cc: netdev, linux-kernel
-Wundef found an (although perhaps harmless) bug:
<-- snip -->
...
CC net/ieee80211/ieee80211_crypt.o
In file included from net/ieee80211/ieee80211_crypt.c:21:
include/net/ieee80211.h:26:5: warning: "WIRELESS_EXT" is not defined
CC net/ieee80211/ieee80211_crypt_wep.o
In file included from net/ieee80211/ieee80211_crypt_wep.c:20:
include/net/ieee80211.h:26:5: warning: "WIRELESS_EXT" is not defined
CC net/ieee80211/ieee80211_crypt_ccmp.o
CC net/ieee80211/ieee80211_crypt_tkip.o
In file included from net/ieee80211/ieee80211_crypt_tkip.c:23:
include/net/ieee80211.h:26:5: warning: "WIRELESS_EXT" is not defined
...
<-- snip -->
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.13-rc3-mm1-full/include/net/ieee80211.h.old 2005-07-22 18:37:57.000000000 +0200
+++ linux-2.6.13-rc3-mm1-full/include/net/ieee80211.h 2005-07-22 18:38:10.000000000 +0200
@@ -22,6 +22,7 @@
#define IEEE80211_H
#include <linux/if_ether.h> /* ETH_ALEN */
#include <linux/kernel.h> /* ARRAY_SIZE */
+#include <linux/wireless.h>
#if WIRELESS_EXT < 17
#define IW_QUAL_QUAL_INVALID 0x10
^ permalink raw reply [flat|nested] 4+ messages in thread
* [-mm patch] include/net/ieee80211.h must #include <linux/wireless.h>
@ 2005-07-27 19:51 Adrian Bunk
2005-07-31 2:24 ` Jouni Malinen
0 siblings, 1 reply; 4+ messages in thread
From: Adrian Bunk @ 2005-07-27 19:51 UTC (permalink / raw)
To: Andrew Morton; +Cc: jgarzik, jkmaline, hostap, netdev, linux-kernel
gcc found an (although perhaps harmless) bug:
<-- snip -->
...
CC net/ieee80211/ieee80211_crypt.o
In file included from net/ieee80211/ieee80211_crypt.c:21:
include/net/ieee80211.h:26:5: warning: "WIRELESS_EXT" is not defined
CC net/ieee80211/ieee80211_crypt_wep.o
In file included from net/ieee80211/ieee80211_crypt_wep.c:20:
include/net/ieee80211.h:26:5: warning: "WIRELESS_EXT" is not defined
CC net/ieee80211/ieee80211_crypt_ccmp.o
CC net/ieee80211/ieee80211_crypt_tkip.o
In file included from net/ieee80211/ieee80211_crypt_tkip.c:23:
include/net/ieee80211.h:26:5: warning: "WIRELESS_EXT" is not defined
...
<-- snip -->
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 22 Jul 2005
--- linux-2.6.13-rc3-mm1-full/include/net/ieee80211.h.old 2005-07-22 18:37:57.000000000 +0200
+++ linux-2.6.13-rc3-mm1-full/include/net/ieee80211.h 2005-07-22 18:38:10.000000000 +0200
@@ -22,6 +22,7 @@
#define IEEE80211_H
#include <linux/if_ether.h> /* ETH_ALEN */
#include <linux/kernel.h> /* ARRAY_SIZE */
+#include <linux/wireless.h>
#if WIRELESS_EXT < 17
#define IW_QUAL_QUAL_INVALID 0x10
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [-mm patch] include/net/ieee80211.h must #include <linux/wireless.h>
2005-07-27 19:51 [-mm patch] include/net/ieee80211.h must #include <linux/wireless.h> Adrian Bunk
@ 2005-07-31 2:24 ` Jouni Malinen
2005-07-31 3:13 ` Jeff Garzik
0 siblings, 1 reply; 4+ messages in thread
From: Jouni Malinen @ 2005-07-31 2:24 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andrew Morton, hostap, jgarzik, linux-kernel, netdev
On Wed, Jul 27, 2005 at 09:51:00PM +0200, Adrian Bunk wrote:
> gcc found an (although perhaps harmless) bug:
>
> CC net/ieee80211/ieee80211_crypt.o
> In file included from net/ieee80211/ieee80211_crypt.c:21:
> include/net/ieee80211.h:26:5: warning: "WIRELESS_EXT" is not defined
> +++ linux-2.6.13-rc3-mm1-full/include/net/ieee80211.h 2005-07-22 18:38:10.000000000 +0200
> +#include <linux/wireless.h>
> #if WIRELESS_EXT < 17
> #define IW_QUAL_QUAL_INVALID 0x10
Wouldn't the proper fix be to just remove this backwards compatibility
code since WIRELESS_EXT is actually 18 in this tree anyway.. Is there
valid need to keep this header file compatible with older kernel
versions?
--
Jouni Malinen PGP id EFC895FA
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [-mm patch] include/net/ieee80211.h must #include <linux/wireless.h>
2005-07-31 2:24 ` Jouni Malinen
@ 2005-07-31 3:13 ` Jeff Garzik
0 siblings, 0 replies; 4+ messages in thread
From: Jeff Garzik @ 2005-07-31 3:13 UTC (permalink / raw)
To: Jouni Malinen; +Cc: Adrian Bunk, Andrew Morton, hostap, netdev, linux-kernel
Jouni Malinen wrote:
> Wouldn't the proper fix be to just remove this backwards compatibility
> code since WIRELESS_EXT is actually 18 in this tree anyway.. Is there
> valid need to keep this header file compatible with older kernel
> versions?
Nope. Ripping out such back-compat code would be quite acceptable.
Jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-07-31 3:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-07-27 19:51 [-mm patch] include/net/ieee80211.h must #include <linux/wireless.h> Adrian Bunk
2005-07-31 2:24 ` Jouni Malinen
2005-07-31 3:13 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2005-07-22 21:39 Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).