From: Jeff Garzik <jgarzik@pobox.com>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: Francois Romieu <romieu@fr.zoreil.com>,
Netdev <netdev@oss.sgi.com>,
renaud.lienhart@free.fr
Subject: Re: [PATCH] forcedeth: Additional ethtool support
Date: Sun, 31 Jul 2005 00:51:04 -0400 [thread overview]
Message-ID: <42EC58B8.7080307@pobox.com> (raw)
In-Reply-To: <42D16656.6000207@colorfullife.com>
Manfred Spraul wrote:
> Not for a nic without complete documentation: What if an arch uses
> 64-bit reads to read two registers at the same time? Not all nics like
> that, for example IIRC natsemi explicitely mandates 32-bit reads.
> x86-64 doesn't, it uses 32-bit reads, but I don't like the idea of using
> memcpy to read registers.
>
> I agree with your other remarks, updated patch attached.
Going through my pending folder, I was about to apply all the queued
forcedeth patches. However, in two cases, you violated Rule #6 of
http://linux.yyz.us/patch-format.html
Please resend ALL forcedeth patches, with proper descriptions, so I
don't have to hunt through previous patch versions, and previous emails,
to match up the correct description to the correct patch.
Jeff
next prev parent reply other threads:[~2005-07-31 4:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-10 11:09 [PATCH] forcedeth: Additional ethtool support Manfred Spraul
2005-07-10 17:28 ` Francois Romieu
2005-07-10 18:17 ` Manfred Spraul
2005-07-10 23:26 ` Francois Romieu
2005-07-31 4:51 ` Jeff Garzik [this message]
2005-07-13 12:39 ` David Hollis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42EC58B8.7080307@pobox.com \
--to=jgarzik@pobox.com \
--cc=manfred@colorfullife.com \
--cc=netdev@oss.sgi.com \
--cc=renaud.lienhart@free.fr \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).