From: Patrick McHardy <kaber@trash.net>
To: Andi Kleen <ak@suse.de>
Cc: netdev@vger.kernel.org, netfilter-devel@lists.netfilter.org
Subject: Re: [PATCH] add new iptables ipt_connbytes match
Date: Fri, 12 Aug 2005 13:57:48 +0200 [thread overview]
Message-ID: <42FC8EBC.1070505@trash.net> (raw)
In-Reply-To: <p73u0hv2xkv.fsf@verdi.suse.de>
Andi Kleen wrote:
> "David S. Miller" <davem@davemloft.net> writes:
>>
>>Won't work in x86 --> x86_64 compat environments.
>
> Thanks for catching it.
>
> The aligned u64 trick probably will
>
> #define aligned_u64 unsigned long long __attribute__((aligned(8)))
>
> It just forces i386 to be aligned too.
>
> Then use aligned_u64 instead of u64/__u64/u_int64_t in all user visible
> places. Similar for signed types.
Unfortunately one of the iptables structures which is needed to get the
ruleset in the kernel (ipt_replace) is differently sized when compiled
for 32/64 bit. IIRC it doesn't work at all currently.
next prev parent reply other threads:[~2005-08-12 11:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-11 20:03 [PATCH] add new iptables ipt_connbytes match Harald Welte
2005-08-11 22:42 ` David S. Miller
2005-08-12 11:39 ` Andi Kleen
2005-08-12 11:57 ` Patrick McHardy [this message]
2005-08-12 12:03 ` Andi Kleen
2005-08-12 15:37 ` Harald Welte
2005-08-12 18:12 ` David S. Miller
2005-08-12 18:23 ` Andi Kleen
2005-08-12 19:03 ` Harald Welte
2005-08-12 19:08 ` Andi Kleen
2005-08-12 19:09 ` David S. Miller
2005-08-13 14:50 ` Harald Welte
2005-08-13 20:54 ` David S. Miller
2005-08-13 15:45 ` [PATCH] introduce and use aligned_u64 in nfnetlink Harald Welte
2005-08-13 20:56 ` David S. Miller
2005-08-13 15:46 ` [PATCH] add new iptables ipt_connbytes match Harald Welte
2005-08-13 20:56 ` David S. Miller
2005-08-12 11:46 ` Harald Welte
2005-08-12 2:52 ` Patrick McHardy
2005-08-12 11:56 ` Harald Welte
2005-08-13 1:20 ` Patrick McHardy
2005-08-13 14:51 ` Harald Welte
2005-08-13 20:59 ` David S. Miller
2005-08-13 20:58 ` David S. Miller
2005-08-16 11:18 ` Amin Azez
2005-08-17 10:29 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42FC8EBC.1070505@trash.net \
--to=kaber@trash.net \
--cc=ak@suse.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).