From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH] add new iptables ipt_connbytes match Date: Fri, 12 Aug 2005 13:57:48 +0200 Message-ID: <42FC8EBC.1070505@trash.net> References: <20050811200349.GN5353@rama.de.gnumonks.org> <20050811.154204.102613246.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, netfilter-devel@lists.netfilter.org Return-path: To: Andi Kleen In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: netfilter-devel-bounces@lists.netfilter.org Errors-To: netfilter-devel-bounces@lists.netfilter.org List-Id: netdev.vger.kernel.org Andi Kleen wrote: > "David S. Miller" writes: >> >>Won't work in x86 --> x86_64 compat environments. > > Thanks for catching it. > > The aligned u64 trick probably will > > #define aligned_u64 unsigned long long __attribute__((aligned(8))) > > It just forces i386 to be aligned too. > > Then use aligned_u64 instead of u64/__u64/u_int64_t in all user visible > places. Similar for signed types. Unfortunately one of the iptables structures which is needed to get the ruleset in the kernel (ipt_replace) is differently sized when compiled for 32/64 bit. IIRC it doesn't work at all currently.