From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7221AC49EA7 for ; Sun, 27 Jun 2021 03:01:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F5B561C4E for ; Sun, 27 Jun 2021 03:01:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230354AbhF0DD5 (ORCPT ); Sat, 26 Jun 2021 23:03:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230104AbhF0DD4 (ORCPT ); Sat, 26 Jun 2021 23:03:56 -0400 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B31E9C061574 for ; Sat, 26 Jun 2021 20:01:33 -0700 (PDT) Received: by mail-pl1-x631.google.com with SMTP id m17so6864236plx.7 for ; Sat, 26 Jun 2021 20:01:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=BD8FXNOGL6nLxco6A1aTNYWsjM2mSp0cjQxg/+vjerc=; b=Zc6I/9v+YH21NYGPNNsjRF/wWUKpwtjPkgvb4WAaGZTVQaDNHLPa0iPXYqW1UPAVLM oi9QBsN9rDasuihT5Bxrnja79+jkzEFiEzwdh8mFg/GOEOLOtcA2V/x6RaoTOGtLJqeJ yHz6uiJhjQu6cjiCy1NugE9D1kxRTczykObYWz+VyTXU3xMl2RrpyxI4wcUSbTl6tcZk oblvzjzpaycwx/d8wasQyj9sZMl06WyzGTqycN5fDn1n3UAW6NT+0rTQYoEIu3pQ7mU8 Vuj3AnZihFEqbh2wkQuQa6ksK50XvRt5zMYa2yJjq0i2flx9QAYODh0y3rjWkxDihyii WBcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BD8FXNOGL6nLxco6A1aTNYWsjM2mSp0cjQxg/+vjerc=; b=pNw6lciPsVQ5E1G8+n+9G8xAR3tHjJBI6S4GlA0S3k+BmyK7uEy2Awx0EcuuWFsxd/ IKDep2hvOnls43oCIenHwGeaxeZE58kbPkdffcWXTl83bYnpqidNztZnIj7Jxs4ZPaC7 G2tozM2FDLzk0gMoEreyL2bMew2QYfgkhGh46sb2dti0/qZ99J5WB94bwtuc3WGKnFJm vDLOHfNgy17fV3B6SVIZ/UYnnZ166AtBGH3tGAi63dQbsyBd9GYE/X4rVBUY6E+brTbk xfGXgkTXjMezlnz1y6nnZufKTkdzEeXCL0x7rbxnjCfc+lZvYX+g/rUnmFggICjM8daI jcWw== X-Gm-Message-State: AOAM530oN5t5KSTiIjavqyQdUsNqGfGgv/aS5hwkoCmf+3sE1OX8CLkz L26kqdN0IbF3wbSm8n//o/I= X-Google-Smtp-Source: ABdhPJzZ5rwDWJD774hnVJgGBShOVk2VC0NJOqvsXv9SU+g4t3/H68IFJnamBbD6X9Wa1aSCgzskiQ== X-Received: by 2002:a17:90a:b28a:: with SMTP id c10mr28559945pjr.59.1624762893262; Sat, 26 Jun 2021 20:01:33 -0700 (PDT) Received: from [192.168.1.121] (99-44-17-11.lightspeed.irvnca.sbcglobal.net. [99.44.17.11]) by smtp.gmail.com with ESMTPSA id k63sm14810575pjh.13.2021.06.26.20.01.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 26 Jun 2021 20:01:32 -0700 (PDT) Subject: Re: [PATCH net-next 6/7] net: bridge: allow the switchdev replay functions to be called for deletion To: Vladimir Oltean , Jakub Kicinski , "David S. Miller" , netdev@vger.kernel.org Cc: Andrew Lunn , Vivien Didelot , Tobias Waldekranz , Jiri Pirko , Ido Schimmel , Roopa Prabhu , Nikolay Aleksandrov , Vladimir Oltean References: <20210625185321.626325-1-olteanv@gmail.com> <20210625185321.626325-7-olteanv@gmail.com> From: Florian Fainelli Message-ID: <42b36391-a496-41f0-18bf-7427211c0117@gmail.com> Date: Sat, 26 Jun 2021 20:01:30 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210625185321.626325-7-olteanv@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 6/25/2021 11:53 AM, Vladimir Oltean wrote: > From: Vladimir Oltean > > When a switchdev port leaves a LAG that is a bridge port, the switchdev > objects and port attributes offloaded to that port are not removed: > > ip link add br0 type bridge > ip link add bond0 type bond mode 802.3ad > ip link set swp0 master bond0 > ip link set bond0 master br0 > bridge vlan add dev bond0 vid 100 > ip link set swp0 nomaster > > VLAN 100 will remain installed on swp0 despite it going into standalone > mode, because as far as the bridge is concerned, nothing ever happened > to its bridge port. > > Let's extend the bridge vlan, fdb and mdb replay functions to take a > 'bool adding' argument, and make DSA and ocelot call the replay > functions with 'adding' as false from the switchdev unsync path, for the > switch port that leaves the bridge. > > Note that this patch in itself does not salvage anything, because in the > current pull mode of operation, DSA still needs to call the replay > helpers with adding=false. This will be done in another patch. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian