From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26110C282C8 for ; Mon, 28 Jan 2019 11:08:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EA3902085A for ; Mon, 28 Jan 2019 11:08:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="uI0l33D3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726772AbfA1LIx (ORCPT ); Mon, 28 Jan 2019 06:08:53 -0500 Received: from mail-lf1-f68.google.com ([209.85.167.68]:46267 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726647AbfA1LIx (ORCPT ); Mon, 28 Jan 2019 06:08:53 -0500 Received: by mail-lf1-f68.google.com with SMTP id f5so11482572lfc.13 for ; Mon, 28 Jan 2019 03:08:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MpxaOD98u2/W2EnfCXhfKuS5vAp87EUppqxMJPhvVzs=; b=uI0l33D3gpOf6ixyHvGRS3XZG2F82Ww7LWcnVen89pnMdaZr2WQ2KMJTdu2/WG2Hln wnG4Mz93U/NYXJy7HvAz0Ib9bGG8uGyGuuzILLD/uJvr0V4iPrkSmHxQhAee+f7MDrnS AdHjEAuFU7yf6pMTUr7sd8EFZxS9ikSsa7y3RBd3CEwHNPYWtry06dReGI7mRC4XuBcD fM0wljHpQkBbzoTQCewpQB9ZLCAylxBuHtkkf/bWvxJafT/nTlpr5/l2BHuePxPNtlN+ +v2XkjKxsr5KrztFUd5hN9mji/UPmDJ/dzKBeE1p63Y4CUSzYqZWg63bB5rv3A7KObsH vzcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=MpxaOD98u2/W2EnfCXhfKuS5vAp87EUppqxMJPhvVzs=; b=B3bXVTSFzChKD5EvevTAEq+Wr+QxnnhUMk8JmMxh7Bow5QAjpmG8/Yx9qGJuc/GJOw nfyPkfa+nKfDy4ren+Tgm8NKyI8cLfJXmu3gcgSS7In0QYjB/yESNzYbppBJmqI+YhS1 m6Nxx4/re9bwVYLSSg+bwT/8Qy1J5JTSwybUgScox/V8OAWRr3+SotSW0RdHzzzKfM6L u4MAG/z8xPxB2u1Oz36oTvNFcgTiT6wQQzPMGteoybhANCaqpok2GquqZUqlISDzRw3V XaCfn08cQABuC/Fe5JSTSvh1MRR4y2Qs6YadICo8jwpVpvbXgA0/16dw93Hmf9FrR91V /DEg== X-Gm-Message-State: AJcUukceCDAIOoz26ZeZCS/kJL/CayaboaVKvRVJTM+A8rFWXvvcOpJY e9Ebi8egOtjE4v40no7KGagzng== X-Google-Smtp-Source: ALg8bN6EpFWDPYkDsh11zJcwrbL5Mvcg0Q/FkbQY6udnXGpUwdQTvBgNVJUQ9XOMzy5xsfcaBv+B4g== X-Received: by 2002:ac2:4194:: with SMTP id z20mr15725322lfh.74.1548673730789; Mon, 28 Jan 2019 03:08:50 -0800 (PST) Received: from wasted.cogentembedded.com ([31.173.84.175]) by smtp.gmail.com with ESMTPSA id o14-v6sm2946164lji.70.2019.01.28.03.08.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Jan 2019 03:08:50 -0800 (PST) Subject: Re: [PATCH 1/7] sh_eth: rename sh_eth_cpu_data::hw_checksum To: Geert Uytterhoeven Cc: netdev , "David S. Miller" , Linux-Renesas , Linux-sh list References: From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <42ba30c2-3de0-411b-63e1-9feef2508d9c@cogentembedded.com> Date: Mon, 28 Jan 2019 14:08:48 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-MW Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 01/28/2019 12:21 PM, Geert Uytterhoeven wrote: > On Sun, Jan 27, 2019 at 6:40 PM Sergei Shtylyov > wrote: >> Commit 62e04b7e0e3c ("sh_eth: rename 'sh_eth_cpu_data::hw_crc'") renamed >> the field to 'hw_checksum' for the Ether DMAC "intelligent checksum", >> however some Ether MACs implement a simpler checksumming scheme, so that >> name now seems misleading. Rename that filed to 'csmr' as the "intelligent >> checkmum" is always controlled by the CSMR register. > > checksum Oops! Do I need to repost? > >> Signed-off-by: Sergei Shtylyov > > Apart from that: > Reviewed-by: Geert Uytterhoeven > >> --- net-next.orig/drivers/net/ethernet/renesas/sh_eth.c >> +++ net-next/drivers/net/ethernet/renesas/sh_eth.c > >> @@ -793,7 +793,7 @@ static struct sh_eth_cpu_data r8a77980_d >> .no_trimd = 1, >> .no_ade = 1, >> .xdfar_rw = 1, >> - .hw_checksum = 1, >> + .csmr = 1, > > Interestingly, I cannot find the CSMR register in the R-Car Gen3 docs? Me niether... But if you remove that flag, the driver stops working due to not doing >>= 16 in sh_eth_rx() anymore. Go figure... :-) > Not introduced by this patch, though. Yep. > Gr{oetje,eeting}s, > > Geert MBR, Sergei