From: Yunsheng Lin <linyunsheng@huawei.com>
To: Jakub Kicinski <kuba@kernel.org>, <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <edumazet@google.com>,
<pabeni@redhat.com>, <peppe.cavallaro@st.com>,
<alexandre.torgue@foss.st.com>, <joabreu@synopsys.com>,
<mcoquelin.stm32@gmail.com>
Subject: Re: [PATCH net-next 2/4] eth: stmmac: let page recycling happen with skbs
Date: Thu, 20 Jul 2023 20:02:18 +0800 [thread overview]
Message-ID: <42c79fdb-a2e7-53b1-d62f-8eb5d91fc7dc@huawei.com> (raw)
In-Reply-To: <20230720010409.1967072-3-kuba@kernel.org>
On 2023/7/20 9:04, Jakub Kicinski wrote:
> stmmac removes pages from the page pool after attaching them
> to skbs. Use page recycling instead.
>
> skb heads are always copied, and pages are always from page
> pool in this driver. We could as well mark all allocated skbs
> for recycling.
LGTM,
Reviewed-by: Yunsheng Lin <linyunsheng@huawei.com>
next prev parent reply other threads:[~2023-07-20 12:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 1:04 [PATCH net-next 0/4] net: page_pool: remove page_pool_release_page() Jakub Kicinski
2023-07-20 1:04 ` [PATCH net-next 1/4] eth: tsnep: let page recycling happen with skbs Jakub Kicinski
2023-07-20 11:55 ` Yunsheng Lin
2023-07-20 1:04 ` [PATCH net-next 2/4] eth: stmmac: " Jakub Kicinski
2023-07-20 12:02 ` Yunsheng Lin [this message]
2023-07-20 1:04 ` [PATCH net-next 3/4] net: page_pool: hide page_pool_release_page() Jakub Kicinski
2023-07-20 12:08 ` Yunsheng Lin
2023-07-24 10:36 ` Ilias Apalodimas
2023-07-20 1:04 ` [PATCH net-next 4/4] net: page_pool: merge page_pool_release_page() with page_pool_return_page() Jakub Kicinski
2023-07-20 12:20 ` Yunsheng Lin
2023-07-24 10:38 ` Ilias Apalodimas
2023-07-20 14:28 ` [PATCH net-next 0/4] net: page_pool: remove page_pool_release_page() Alexander Lobakin
2023-07-22 2:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42c79fdb-a2e7-53b1-d62f-8eb5d91fc7dc@huawei.com \
--to=linyunsheng@huawei.com \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).