From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>
Cc: netdev <netdev@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: PHY reset may still be asserted during MDIO probe
Date: Fri, 9 Jul 2021 21:14:18 +0300 [thread overview]
Message-ID: <42ce02e9-09f1-55b9-775d-01ae6b40e36f@ti.com> (raw)
In-Reply-To: <CAMuHMdXno2OUHqsAfO0z43JmGkFehD+FJ2dEjEsr_P53oAAPxA@mail.gmail.com>
On 09/07/2021 18:33, Geert Uytterhoeven wrote:
> Hi all,
>
> I'm investigating a network failure after kexec on the Renesas Koelsch
> and Salvator-XS development boards, using the sh-eth or ravb driver.
>
> During normal boot, the Ethernet interface is working fine:
>
> libphy: get_phy_c22_id:814: sh_mii: mdiobus_read() MII_PHYSID1 returned 34
> libphy: get_phy_c22_id:824: sh_mii: mdiobus_read() MII_PHYSID2 returned 5431
> libphy: get_phy_c22_id:832: sh_mii: phy_id = 0x00221537
> libphy: get_phy_device:895: sh_mii: get_phy_c22_id() returned 0
> fwnode_mdiobus_register_phy:109: sh_mii: get_phy_device() returned (ptrval)
> fwnode_mdiobus_phy_device_register:46: sh_mii: fwnode_irq_get() returned 191
> libphy: mdiobus_register_gpiod:48: mdiodev->reset_gpio = (ptrval)
> mdio_bus ee700000.ethernet-ffffffff:01:
> mdiobus_register_device:88: assert MDIO reset
> libphy: mdio_device_reset:124: calling gpiod_set_value_cansleep(..., 1)
> mdio_bus ee700000.ethernet-ffffffff:01: phy_device_register:931:
> deassert PHY reset
> libphy: mdio_device_reset:124: calling gpiod_set_value_cansleep(..., 0)
> Micrel KSZ8041RNLI ee700000.ethernet-ffffffff:01: phy_probe:3026:
> deassert PHY reset
> libphy: mdio_device_reset:124: calling gpiod_set_value_cansleep(..., 0)
> fwnode_mdiobus_phy_device_register:75: sh_mii:
> phy_device_register() returned 0
> fwnode_mdiobus_register_phy:137: sh_mii:
> fwnode_mdiobus_phy_device_register() returned 0
> of_mdiobus_register:188: of_mdiobus_register_phy(sh_mii,
> /soc/ethernet@ee700000/ethernet-phy@1, 1) returned 0
> sh-eth ee700000.ethernet eth0: Base address at 0xee700000,
> 2e:09:0a:00:6d:85, IRQ 126.
>
> When using kexec, the PHY reset is asserted before starting the
> new kernel:
>
> Micrel KSZ8041RNLI ee700000.ethernet-ffffffff:01: phy_detach:1759:
> assert PHY reset
> libphy: mdio_device_reset:124: calling gpiod_set_value_cansleep(..., 1)
> kexec_core: Starting new kernel
> Bye!
>
> The new kernel fails to probe the PHY, as the PHY reset is still
> asserted:
>
> libphy: get_phy_c22_id:814: sh_mii: mdiobus_read() MII_PHYSID1
> returned 65535
> libphy: get_phy_c22_id:824: sh_mii: mdiobus_read() MII_PHYSID2
> returned 65535
> libphy: get_phy_c22_id:832: sh_mii: phy_id = 0xffffffff
> libphy: get_phy_device:895: sh_mii: get_phy_c22_id() returned -19
> fwnode_mdiobus_register_phy:109: sh_mii: get_phy_device() returned -ENODEV
> of_mdiobus_register:188: of_mdiobus_register_phy(sh_mii,
> /soc/ethernet@ee700000/ethernet-phy@1, 1) returned -19
> mdio_bus ee700000.ethernet-ffffffff: MDIO device at address 1 is missing.
> sh-eth ee700000.ethernet eth0: Base address at 0xee700000,
> 2e:09:0a:00:6d:85, IRQ 126.
>
> This issue can also be reproduced using unbind:
>
> # echo ee700000.ethernet > /sys/bus/platform/drivers/sh-eth/unbind
> sh-eth ee700000.ethernet eth0: Link is Down
> Micrel KSZ8041RNLI ee700000.ethernet-ffffffff:01: phy_detach:1759:
> assert PHY reset
> libphy: mdio_device_reset:124: calling gpiod_set_value_cansleep(..., 1)
> Micrel KSZ8041RNLI ee700000.ethernet-ffffffff:01: phy_remove:3120:
> assert PHY reset
> libphy: mdio_device_reset:124: calling gpiod_set_value_cansleep(..., 1)
> mdio_bus ee700000.ethernet-ffffffff:01: phy_device_remove:974:
> assert PHY reset
> libphy: mdio_device_reset:124: calling gpiod_set_value_cansleep(..., 1)
>
> and bind:
>
> # echo ee700000.ethernet > /sys/bus/platform/drivers/sh-eth/bind
> (same log as kexec boot)
>
> I think fwnode_mdiobus_register_phy() should do the PHY reset (assert +
> deassert) before calling get_phy_device(), but currently that happens
> in phy_device_register(), which is called later.
Seems like similar to [1], only PHY ID in DT compatible is current w/a.
[1] https://lkml.org/lkml/2020/10/23/750
--
Best regards,
grygorii
prev parent reply other threads:[~2021-07-09 18:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 15:33 PHY reset may still be asserted during MDIO probe Geert Uytterhoeven
2021-07-09 15:54 ` Russell King (Oracle)
2021-07-09 16:22 ` Andrew Lunn
2021-07-09 18:14 ` Grygorii Strashko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42ce02e9-09f1-55b9-775d-01ae6b40e36f@ti.com \
--to=grygorii.strashko@ti.com \
--cc=andrew@lunn.ch \
--cc=geert@linux-m68k.org \
--cc=hkallweit1@gmail.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).