From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B64AC43381 for ; Sun, 3 Mar 2019 17:22:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2A37420835 for ; Sun, 3 Mar 2019 17:22:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="r7BO3deg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726535AbfCCRWG (ORCPT ); Sun, 3 Mar 2019 12:22:06 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:35949 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726439AbfCCRWF (ORCPT ); Sun, 3 Mar 2019 12:22:05 -0500 Received: by mail-wm1-f67.google.com with SMTP id j125so2504966wmj.1 for ; Sun, 03 Mar 2019 09:22:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=o8JLLJhBy4bhDywR/fdZ2AKGIhhVt41eOzJOXGKu0wE=; b=r7BO3degMkX1t41/0DkYFIeI9/gNUpTs/g17lYrKFLvgMEDhL9pmRMXztPJTb/2hK0 XH+C73ujjKCzOu0YG70Zri0ky9paIv04Plr09ffyJqbFEaTjbJOP0mf2vKw8jyPR54S2 qbh9EhvRT9dp6rnGXoekeGgmTuTbyr1OWkiVTEDZ8cbuw46nnK1xgBFkPiEoCWtw3pHG Kz6bgDK78/P9e2kVD+OMw6jF1v/z+a7JXbUbPsAfGrnCuhnmas/ai/t2WTp1JzSYd9v0 CiUgNjZpjGijjRfEJ7V39wvoVK4ZcvzKoT27Z5aS8EgVjlg3HVzOsz3EG4Jns/rMPbRT 4l+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=o8JLLJhBy4bhDywR/fdZ2AKGIhhVt41eOzJOXGKu0wE=; b=MjSJQqoj4pGEBJDFg634lYObsnRJThXg945BnziEsP4tWk8DHWxpVQfcjZ40j9cz6G JJt8h5nEVFK562xvPEcZqY8Kr+Vr/osz/zRCjqRTNQTHpEGY/VjJQwun8MEvXHq+9xJA rp+NWzLAUFYogWhF8Z/MPC1zbSNOuPMoPOuOSlIf56tcyQbYr7ThXFQvcj1Qc9V3Der5 uXWvxRKXB1CoGBYxWKCKyZsW16pqxDqMi27OY+WjX5+gmBa/GVJzSeuBmrvaoXxfp81f 7XW7JbXa9lW/XUqCN5yjDHih/dmgVsf3vlW5UPQpiF0PfdGXPNAAkC91FFdO/51SXsjU +WWw== X-Gm-Message-State: AHQUAubenrrD5Vr0qyaOdb0uYfZs6gv75yCwMRPhmwq/6wYQ0lHsmL4u 6Rz3gcJQQWztmxizgE7iW7xFJHU/ X-Google-Smtp-Source: APXvYqwDFzbobX9eYg6DloCtUbCESMwnfnDnk2tjhnL/QknfeveUgeiyY34CAVbGn9lx3HKkwh0dSg== X-Received: by 2002:a1c:700a:: with SMTP id l10mr9725912wmc.13.1551633722915; Sun, 03 Mar 2019 09:22:02 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:35a8:f48d:4b19:96c9? (p200300EA8BF1E20035A8F48D4B1996C9.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:35a8:f48d:4b19:96c9]) by smtp.googlemail.com with ESMTPSA id o12sm16431448wre.0.2019.03.03.09.22.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 Mar 2019 09:22:02 -0800 (PST) Subject: [PATCH net-next 2/2] net: phy: aquantia: use new function strreplace_nonalnum From: Heiner Kallweit To: Florian Fainelli , Andrew Lunn , David Miller Cc: "netdev@vger.kernel.org" References: Message-ID: <42f2e064-181c-087e-68b1-64d2d6f13e0e@gmail.com> Date: Sun, 3 Mar 2019 18:21:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Use new function strreplace_nonalnum to simplify the code. Signed-off-by: Heiner Kallweit --- drivers/net/phy/aquantia_hwmon.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/net/phy/aquantia_hwmon.c b/drivers/net/phy/aquantia_hwmon.c index 19c4c280a..d47b3ed16 100644 --- a/drivers/net/phy/aquantia_hwmon.c +++ b/drivers/net/phy/aquantia_hwmon.c @@ -226,20 +226,12 @@ int aqr_hwmon_probe(struct phy_device *phydev) struct device *dev = &phydev->mdio.dev; struct device *hwmon_dev; char *hwmon_name; - int i, j; hwmon_name = devm_kstrdup(dev, dev_name(dev), GFP_KERNEL); if (!hwmon_name) return -ENOMEM; - for (i = j = 0; hwmon_name[i]; i++) { - if (isalnum(hwmon_name[i])) { - if (i != j) - hwmon_name[j] = hwmon_name[i]; - j++; - } - } - hwmon_name[j] = '\0'; + strreplace_nonalnum(hwmon_name, 0); hwmon_dev = devm_hwmon_device_register_with_info(dev, hwmon_name, phydev, &aqr_hwmon_chip_info, NULL); -- 2.21.0